Pr Updates. Added Unit Testing

bcgov · Dec 23, 2019 · 70d1496 · 70d1496
1 parent e035f4a
commit 70d1496
Show file tree

Hide file tree

Showing 6 changed files with 42 additions and 6 deletions.
diff --git a/bcrs-ui/public/index.html b/bcrs-ui/public/index.html
@@ -8,8 +8,6 @@
     <link rel="icon" href="dummy-not-used-do-not-remove">
     <link rel="icon" href="<%= BASE_URL %>favicon.ico">
     <link rel="preload" href="<%= BASE_URL %>fonts/materialdesignicons-webfont.927457ed.woff2" as="font" type="font/woff2" crossorigin>
-    <link rel="stylesheet" href="<%= BASE_URL %>css/addresscomplete-2.00.min.css">
-    <script type="text/javascript" src="<%= BASE_URL %>js/addresscomplete-2.00.min.js" defer></script>
   </head>
   <body>
     <noscript>

diff --git a/bcrs-ui/src/App.vue b/bcrs-ui/src/App.vue
@@ -1,12 +1,12 @@
 <template>
-  <div id="app">
+  <v-app id="app">
     <div class="app-body">
       <main>
         <router-view />
       </main>
     </div>
 
-  </div>
+  </v-app>
 </template>
 
 <script lang="ts">

diff --git a/bcrs-ui/src/mixins/resource-lookup-mixin.ts b/bcrs-ui/src/mixins/resource-lookup-mixin.ts
@@ -14,6 +14,8 @@ export default class ResourceLookupMixin extends Vue {
 
   /**
    * Method to return the specified message
+   *
+   * @param id ID a number indicating the id of the resource to look up.
    */
   getName (id: number): string {
     const user: ResourceExampleIF | undefined = this.resourceModel && this.resourceModel.find(user => user.id === id)
@@ -22,6 +24,8 @@ export default class ResourceLookupMixin extends Vue {
 
   /**
    * Method to return the specified display Name
+   *
+   * @param id ID a number indicating the id of the resource to look up.
    */
   getMessage (id: number): string {
     const user: ResourceExampleIF | undefined = this.resourceModel && this.resourceModel.find(user => user.id === id)

diff --git a/bcrs-ui/src/utils/config-helper.ts b/bcrs-ui/src/utils/config-helper.ts
@@ -6,7 +6,6 @@ import axios from '@/utils/axios-auth'
  * @return A Promise to get & set session storage URLS with appropriate paths
  */
 export const fetchConfig = (): Promise<any> => {
-  console.log('Fetch Config called')
   const origin: string = window.location.origin
   const vueAppPath: string = process.env.VUE_APP_PATH
   const vueAppAuthPath:string = process.env.VUE_APP_AUTH_PATH

diff --git a/bcrs-ui/src/views/StateExample.vue b/bcrs-ui/src/views/StateExample.vue
@@ -40,7 +40,7 @@ import { StateModelIF, ActionBindingIF } from '@/interfaces'
     ResourceExample
   }
 })
-export default class Testing extends Mixins(ResourceLookupMixin) {
+export default class StateExample extends Mixins(ResourceLookupMixin) {
   // Initialize State
   @State stateModel!: StateModelIF
 

diff --git a/bcrs-ui/tests/unit/stateExample.spec.ts b/bcrs-ui/tests/unit/stateExample.spec.ts
@@ -0,0 +1,35 @@
+// Libraries
+import Vue from 'vue'
+import Vuetify from 'vuetify'
+import { store } from '@/store'
+import { shallowMount } from '@vue/test-utils'
+
+// Components
+import StateExample from '@/views/StateExample.vue'
+import { ResourceExample } from '@/components/common'
+
+Vue.use(Vuetify)
+let vuetify = new Vuetify({})
+
+describe('HelloWorld.vue', () => {
+  let wrapper: any
+
+  beforeEach(() => {
+    // create wrapper for Dashboard
+    // this stubs out the sub-component
+    wrapper = shallowMount(StateExample, { store, vuetify })
+  })
+
+  afterEach(() => {
+    wrapper.destroy()
+  })
+
+  it('renders the sub-components properly', () => {
+    expect(wrapper.find(ResourceExample).exists()).toBe(true)
+  })
+
+  it('displays the appropriate welcome message', () => {
+    expect(wrapper.vm.$el.querySelector('.stateExample').textContent)
+      .toContain('Congratulations... it worked!')
+  })
+})