18788 Added correct-name sub-components for AML #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2023 11:20
- added CorrectAmlNumbered sub-component - updated whitespace in CorrectName - added new sub-components, prop and options to CorrectName - removed unneeded layout in CorrectNameToNumber
severinbeauvais
requested review from
jamespaologarcia,
tshyun24,
leodube-aot and
ketaki-deodhar
severinbeauvais
commented
Dec 22, 2023
There was a problem hiding this comment.
Sample new layout (whitespace):
severinbeauvais
commented
Dec 22, 2023
| @@ -26,6 +26,7 @@ | |||
| <v-text-field | |||
| id="nr-number" | |||
| v-model="nrNumber" | |||
| autofocus | |||
There was a problem hiding this comment.
We need to be careful when using this (because too many doesn't work well), but in specific cases this brings focus to the text field, which is very nice.
severinbeauvais
commented
Dec 22, 2023
| @@ -4,17 +4,13 @@ | |||
| ref="form" | |||
| v-model="formValid" | |||
| > | |||
| <v-row no-gutters> | |||
| <v-col> | |||
There was a problem hiding this comment.
A single row with a single column is a lazy way to lay out a flex panel, and in fact it's not needed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#18788
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).