18722 Add Jurisdiction component

[leodube-aot]

Issue #: /bcgov/entity#18722

Description of changes:

• Added Jurisdiction component

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

[leodube-aot]

This is to help complete bcgov/entity#18722. I created a ticket to replace the duplicate component in Namerequest, and to add unit tests and finish up the storybook for this component:

https://app.zenhub.com/workspaces/entities-team-space-6143567664fb320019b81f39/issues/gh/bcgov/entity/18973

[severinbeauvais]

In the future, try to keep the Storybook build changes in a separate commit from your code changes, so I can ignore them. (161 files!!!)

[leodube-aot]

Does this require another storybook build before merge?

Edit: merging, if needed I'll create a new PR

[JazzarKarim]

LGTM!

[severinbeauvais]

Does this require another storybook build before merge?

In main branch, yes, because the SB build files are used for https://bcgov.github.io/bcrs-shared-components/.

In this feature branch, the SB files aren't used, except locally for your testing.

When we merge this feature branch into main (or rename it), then one of us will have to do a SB build and commit those files.

[leodube-aot]

In main branch, yes, because the SB build files are used for https://bcgov.github.io/bcrs-shared-components/.

In this feature branch, the SB files aren't used, except locally for your testing.

This was merged into main branch since it is not a Vue 3 component (it was mainly just copy pasted Vue 2 code from Namerequest). Should it have been to the feature branch? Or should I create a SB PR?

[severinbeauvais]

This was merged into main branch since it is not a Vue 3 component (it was mainly just copy pasted Vue 2 code from Namerequest). Should it have been to the feature branch? Or should I create a SB PR?

Hahaha, I am reviewing too many PRs at once!

Yes, this was correctly merged into main (Vue2) branch.

Yes, Storybook should be rebuilt and committed. Let me publish the changes in THIS PR first, and then you can rebase and create a new one for SB.

[severinbeauvais]

Yes, Storybook should be rebuilt and committed. Let me publish the changes in THIS PR first, and then you can rebase and create a new one for SB.

I have a better idea -- since I'm committing to the main branch anyway, I'll rebuild Storybook along the way.

[severinbeauvais]

I have a better idea -- since I'm committing to the main branch anyway, I'll rebuild Storybook along the way.

lerna notice
Successfully published:
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
lerna success published 25 packages

There are many updated packages because they depended on shared enums.

[severinbeauvais]

And also...

https://bcgov.github.io/bcrs-shared-components/?path=/story/component-jurisdiction--default