Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

18024 Update DatePicker to not validate while still open #210

Merged
merged 2 commits into from
Nov 27, 2023
Merged

18024 Update DatePicker to not validate while still open #210

merged 2 commits into from
Nov 27, 2023

Conversation

leodube-aot
Copy link
Collaborator

@leodube-aot leodube-aot commented Nov 27, 2023 •
edited
Loading

Issue #: /bcgov/entity#18024

Description of changes:

  • Fix UI issue described in image below
  • Only evaluate inputRules when dateText is not null
  • Set default for initialValue to be null instead of an empty string
  • I think it is ok if error message remains after initial input attempt (ie. They open the datepicker, click "Ok" or "Cancel" for an invalid date, then when they re-open the picker the validation message will not get cleared).
  • New story: datePickerValidation can be used for testing the fix
285523902-9ff92583-80f6-4786-8804-433ffc2c7d4c

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

@leodube-aot leodube-aot self-assigned this Nov 27, 2023
JazzarKarim
JazzarKarim approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@severinbeauvais severinbeauvais merged commit 320d4ac into bcgov:main Nov 27, 2023
4 checks passed
@severinbeauvais
Copy link
Collaborator 

lerna notice
Successfully published:
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
 - @bcrs-shared-components/[email protected]
lerna success published 3 packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JazzarKarim JazzarKarim JazzarKarim approved these changes

@severinbeauvais severinbeauvais severinbeauvais approved these changes

@jamespaologarcia jamespaologarcia Awaiting requested review from jamespaologarcia

@ketaki-deodhar ketaki-deodhar Awaiting requested review from ketaki-deodhar

@PaulGarewal PaulGarewal Awaiting requested review from PaulGarewal

@tshyun24 tshyun24 Awaiting requested review from tshyun24

Assignees

@leodube-aot leodube-aot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leodube-aot @severinbeauvais @JazzarKarim