Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18273 Add show-current to DatePicker #208

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Conversation

leodube-aot
Copy link
Collaborator

Issue #: /bcgov/entity#18273

Description of changes:
I needed specific functionality to improve the DatePicker for #18273. Currently, when we add a min restriction on the DatePicker in the Agm Extension Request component, the min valid date can be several months, or even over a year into the future. When the picker loads, is does not default to the earliest valid date, and instead shows the current date.

Screenshot 2023-11-20 at 1 17 47 PM

Passing the minimum date to showCurrent will now display the earliest valid date by default when the component loads.

<DatePicker
  ...
  initialValue="2025-06-06"   // initialValue also needs to be provided for the title date button to update as well
  minDate="2025-06-06"
  showCurrent="2025-06-06"
  ...
/>
Screenshot 2023-11-20 at 1 40 50 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

docs/.nojekyll Outdated Show resolved Hide resolved
Copy link
Collaborator

@ketaki-deodhar ketaki-deodhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@JazzarKarim JazzarKarim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@severinbeauvais severinbeauvais merged commit 9b9a41c into bcgov:main Nov 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants