18536 Additions for amalgamations + misc cleanup #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
severinbeauvais
force-pushed
the
18536
branch
from
3dca1f8 to
dabdd14
Compare
severinbeauvais
commented
Nov 16, 2023
severinbeauvais
force-pushed
the
18536
branch
from
5688a9a to
c1e8130
Compare
- added amalgamation filing codes - added amalgamation filing name - added amalgamation filing types
- now import CorpTypeCd from module (not enums/) - added missing import to interfaces package.json
severinbeauvais
force-pushed
the
18536
branch
from
05c3a10 to
04ba46b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#18536
I highly recommend that you review commits 1-3 independently, since the last commit (Storybook update) has 169 changed files that you don't really have to review. 😛
Description of changes:
Commit 1:
Commit 2:
Commit 3:
Commit 4:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).