Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18513 Changed transition from "expand" to "slide-y" #202

Merged
merged 1 commit into from
Nov 9, 2023
Merged

18513 Changed transition from "expand" to "slide-y" #202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/expandable-help/ExpandableHelp.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<span class="pl-2 help-label">{{ !helpToggle ? helpLabel : 'Hide Help' }}</span>
</div>

<v-expand-transition>
<v-slide-y-transition hide-on-leave>
Copy link
Collaborator Author

@severinbeauvais severinbeauvais Nov 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried "expand" with hide-on-leave (which has no effect), and "scale" (which explodes on the screen kinda weird), and "scroll-y" (which looks almost the same as slide-y). Ultimately, "slide-y" with the option looks best to me.

<div
v-show="helpToggle"
class="help-section mt-3 pa-6"
Expand All @@ -29,7 +29,7 @@
</div>
</div>
</div>
</v-expand-transition>
</v-slide-y-transition>
</div>
</template>

Expand Down
Loading