- deleted unneeded props

- updated fetchAndValidateNr parameters
- updated unit tests

src/components/correct-name/CorrectNameRequest.vue

@@ -86,7 +86,6 @@ import { Component, Emit, Mixins, Prop, Watch } from 'vue-property-decorator'
 import { NameRequestMixin } from '@bcrs-shared-components/mixins'
 import { NameRequestIF } from '@bcrs-shared-components/interfaces'
 import { CorrectNameOptions } from '@bcrs-shared-components/enums'
-import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module'
 
 @Component({})
 export default class CorrectNameRequest extends Mixins(NameRequestMixin) {
@@ -95,8 +94,6 @@ export default class CorrectNameRequest extends Mixins(NameRequestMixin) {
     form: HTMLFormElement
   }
 
-  @Prop({ required: true }) readonly businessId!: string
-  @Prop({ required: true }) readonly entityType!: CorpTypeCd // not used
   @Prop({ required: true }) readonly fetchAndValidateNr!: (...args) => Promise<NameRequestIF>
   @Prop({ required: true }) readonly formType!: CorrectNameOptions
   @Prop({ required: true }) readonly nameRequest!: NameRequestIF
@@ -163,8 +160,7 @@ export default class CorrectNameRequest extends Mixins(NameRequestMixin) {
     if (this.formType === CorrectNameOptions.CORRECT_NEW_NR) {
       try {
         // validate and return the name request data
-        const nr = await this.fetchAndValidateNr(this.nrNumber, this.businessId, this.applicantPhone,
-          this.applicantEmail)
+        const nr = await this.fetchAndValidateNr(this.nrNumber, this.applicantPhone, this.applicantEmail)
 
         // emit new data
         this.emitNameRequest(nr)

tests/unit/CorrectNameRequest.spec.ts

@@ -37,13 +37,10 @@ const nameRequest = {
   }
 }
 
-const fetchAndValidateNr = (nrNumber, businessId, applicantPhone, applicantEmail) => {
+const fetchAndValidateNr = (nrNumber, applicantPhone, applicantEmail) => {
   if (nrNumber !== nameRequest.nrNum) {
     throw new Error('wrong NR number')
   }
-  if (businessId && businessId !== nameRequest.corpNum) {
-    throw new Error('wrong business id')
-  }
   if (applicantEmail && applicantEmail !== nameRequest.applicants.emailAddress) {
     throw new Error('wrong applicant email')
   }
@@ -255,21 +252,6 @@ describe('CorrectNameRequest', () => {
     expect(getLastEvent(wrapper, 'saved')).toBe(false)
   })
 
-  it('emits error and not saved when the process is done but business id doesn\'t match', async () => {
-    wrapper = wrapperFactory()
-
-    // Set values and submit form
-    wrapper.vm.nrNumber = 'NR 1234567'
-    await wrapper.setProps({ formType: 'correct-new-nr', businessId: 'BC0000000' })
-    await flushPromises()
-
-    expect(wrapper.vm.formValid).toBe(true)
-
-    // verify form emission
-    expect(getLastEvent(wrapper, 'error')).toBe('wrong business id')
-    expect(getLastEvent(wrapper, 'saved')).toBe(false)
-  })
-
   it('emits done and verify data changes', async () => {
     wrapper = wrapperFactory()