Merge pull request #126 from pwei1018/feature-ci-upgrade

Update notify api CI
bcgov · Apr 25, 2024 · e45d4a6 · e45d4a6
2 parents b7f70f6 + ec270e6
commit e45d4a6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/.github/workflows/notify-api-ci.codecov.yaml b/.github/workflows/notify-api-ci.codecov.yaml
@@ -30,7 +30,7 @@ jobs:
       - name: Download artifacts
         uses: dawidd6/action-download-artifact@v3
         with:
-          name: backend-coverage-${{ github.sha }}
+          name: notifyapicoveragefile
           run_id: ${{ github.event.workflow_run.id }}
       - name: Upload to Codecov
         uses: codecov/codecov-action@v4

diff --git a/.github/workflows/notify-api-ci.yaml b/.github/workflows/notify-api-ci.yaml
@@ -1,7 +1,7 @@
 name: Notify API CI
 
 on:
-  push:
+  pull_request:
     paths:
       - "notify-api/**"
   workflow_dispatch:
@@ -116,5 +116,5 @@ jobs:
 
       - uses: actions/upload-artifact@v4
         with:
-          name: backend-coverage-${{ github.sha }}
+          name: notifyapicoveragefile
           path: ./notify-api/coverage.xml
diff --git a/notify-api/README.md b/notify-api/README.md
@@ -19,7 +19,6 @@ GitHub Pages (https://guides.github.com/features/pages/) are a neat way to docum
 
 ## Security
 
-
 ## Files in this repository
 
 ## Environment Variables
Original file line number	Diff line number	Diff line change
Expand Up		@@ -19,7 +19,6 @@ GitHub Pages (https://guides.github.com/features/pages/) are a neat way to docum

		## Security


		## Files in this repository

		## Environment Variables
Expand Down