Merge pull request #131 from pwei1018/main

Fixed vault issue.
bcgov · Apr 26, 2024 · 1251966 · 1251966
2 parents 9a5ba8e + 8083307
commit 1251966
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/.github/workflows/notify-api-ci.codecov.yaml b/.github/workflows/notify-api-ci.codecov.yaml
@@ -2,7 +2,7 @@ name: Notify Codecov CI
 
 on:
   workflow_run:
-    workflows: ["Notify API CI"]
+    workflows: ["Notify API CI1"]
     types:
       - completed
 

diff --git a/.github/workflows/notify-api-ci.yaml b/.github/workflows/notify-api-ci.yaml
@@ -114,7 +114,11 @@ jobs:
         run: |
           poetry run pytest
 
-      - uses: actions/upload-artifact@v4
+      - name: Upload to Codecov
+        uses: codecov/codecov-action@v4
         with:
-          name: notifyapicoveragefile
-          path: ./notify-api/coverage.xml
+          file: coverage.xml
+          flags: notifapi
+          name: codecov-notifyapi
+          token: ${{ secrets.CODECOV_TOKEN }}
+          verbose: true
diff --git a/notify-api/devops/vaults.gcp.env b/notify-api/devops/vaults.gcp.env
@@ -1,4 +1,4 @@
-TRACING_ENABLE="op://CD/$APP_ENV/notify-api/TRACING_ENABLE"
+TRACING_ENABLE="True"
 JWT_OIDC_WELL_KNOWN_CONFIG="op://keycloak/$APP_ENV/jwt-base/JWT_OIDC_WELL_KNOWN_CONFIG"
 JWT_OIDC_ISSUER="op://keycloak/$APP_ENV/jwt-base/JWT_OIDC_ISSUER"
 JWT_OIDC_JWKS_CACHE_TIMEOUT="op://keycloak/$APP_ENV/jwt-base/JWT_OIDC_JWKS_CACHE_TIMEOUT"