feat: implement report problem feature, revert pn change #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryce McMath <[email protected]>
bryce-mcmath
commented
Dec 12, 2024
| @@ -113,7 +114,6 @@ export class AppContainer implements Container { | |||
| lokiUrl: Config.REMOTE_LOGGING_URL, | |||
| lokiLabels: { | |||
| application: getApplicationName().toLowerCase(), | |||
| job: 'react-native-logs', | |||
There was a problem hiding this comment.
job is now specified by the remote logger, if we also specify it here, every job will be the same whether they are incident reports or remote logging sessions. Having separate jobs should allow us to have different lifespans for each job type
| @@ -190,7 +190,7 @@ const useInitializeBCAgent = () => { | |||
|
|
|||
| if (store.preferences.usePushNotifications) { | |||
| logger.info('Activating push notifications...') | |||
| await activate(newAgent) | |||
| activate(newAgent) | |||
There was a problem hiding this comment.
I'm hoping this reverted line will fix the issue Shel mentioned that happens during SauceLabs app initialization
Signed-off-by: Bryce McMath <[email protected]>
Signed-off-by: Bryce McMath <[email protected]>
Signed-off-by: Bryce McMath <[email protected]>
|
jleach
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving in draft until Bifold package deps are ready and updated but it's here if you want to see how the Bifold changes are used. Depends on: