fix: issue building on main branch #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleach
force-pushed
the
fix/debug-action
branch
from
26eb884 to
f85df62
Compare
jleach
force-pushed
the
fix/debug-action
branch
2 times, most recently
from
805873e to
17b56ac
Compare
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
Signed-off-by: Jason C. Leach <[email protected]>
jleach
force-pushed
the
fix/debug-action
branch
from
189e716 to
0fae985
Compare
|
cvarjao
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the workflow would fail if the grep command in the build script didn't find any matching files. Because GitHub Actions runs shell commands with the pipefail option, a non-zero exit code from grep (which occurs when no matches are found) causes the entire pipeline to fail. This PR addresses this by ensuring the grep command always returns a successful exit code, preventing the script from failing in these cases.