-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: alt person flow framing skeleton #2228
Conversation
Signed-off-by: Bryce McMath <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snapshot just updated to include new option
icon={'help-circle'} | ||
accessibilityLabel={t('PersonCredential.HelpLink')} | ||
testID={testIdWithKey('Help')} | ||
onPress={() => null} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we have an actual external URL to navigate to for help content, we can add that here. For now the button does nothing.
icon={'help-circle'} | ||
accessibilityLabel={t('PersonCredential.HelpLink')} | ||
testID={testIdWithKey('Help')} | ||
onPress={() => null} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added one placeholder screen to show the process for adding new screens and steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the alt person flow is enabled, the start process button navigates to the new stack. Otherwise, everything is exactly the same.
}) | ||
|
||
const steps: SetupStep[] = useMemo(() => { | ||
return [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting these might / will probably come from the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True
This PR adds in the first steps towards building out the verified in person workflow as a developer option. Some of the content is just placeholders and should be replaced with dynamic content when we get to that stage for each step. But the placeholder's for the step screen should make it pretty easy to update as most of the styling for that screen is already done. I did have to use a colour hex that isn't in our theme to match the wireframes.
Here's what it looks like: