Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: alt person flow framing skeleton #2228

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

bryce-mcmath
Copy link
Contributor

This PR adds in the first steps towards building out the verified in person workflow as a developer option. Some of the content is just placeholders and should be replaced with dynamic content when we get to that stage for each step. But the placeholder's for the step screen should make it pretty easy to update as most of the styling for that screen is already done. I did have to use a colour hex that isn't in our theme to match the wireframes.

Here's what it looks like:
alt_person_flow

Copy link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Snapshot just updated to include new option

icon={'help-circle'}
accessibilityLabel={t('PersonCredential.HelpLink')}
testID={testIdWithKey('Help')}
onPress={() => null}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we have an actual external URL to navigate to for help content, we can add that here. For now the button does nothing.

icon={'help-circle'}
accessibilityLabel={t('PersonCredential.HelpLink')}
testID={testIdWithKey('Help')}
onPress={() => null}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added one placeholder screen to show the process for adding new screens and steps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the alt person flow is enabled, the start process button navigates to the new stack. Otherwise, everything is exactly the same.

@bryce-mcmath bryce-mcmath enabled auto-merge (squash) October 21, 2024 21:45
})

const steps: SetupStep[] = useMemo(() => {
return [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting these might / will probably come from the server.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True

@bryce-mcmath bryce-mcmath merged commit 7233111 into main Oct 21, 2024
15 checks passed
@bryce-mcmath bryce-mcmath deleted the feat/alt-person-flow-framing branch October 21, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants