Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for android attestation using new native module #1586

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

bryce-mcmath
Copy link
Contributor

This PR installs and makes use of the new attestation native module published from the bifold repo. With this and mobile-attestation-vc-controller set up with Traction you can fully test Google (and Apple) attestation.

To test, you must ensure you are using a non-booted Android device (not an emulator) and do the following setup steps:

  1. Follow all the steps to set up and run the controller in mobile-attestation-vc-controller repo
  2. Create an ngrok tunnel to port 5000
  3. Set your Traction instance webhook url to your ngrok url from the previous step
  4. Enable the Attestation Support toggle in BC Wallet dev settings
  5. Scan a connection QR code from traction with your BC Wallet
  6. Watch the magic!

Screenshot 2023-11-04 at 5 50 44 PM

Copy link

sonarqubecloud bot commented Nov 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bryce-mcmath bryce-mcmath marked this pull request as ready for review November 5, 2023 01:06
@bryce-mcmath bryce-mcmath requested a review from jleach November 6, 2023 22:07
@bryce-mcmath bryce-mcmath assigned wadeking98 and unassigned wadeking98 Nov 6, 2023
@bryce-mcmath bryce-mcmath merged commit d808c48 into main Nov 8, 2023
9 checks passed
@bryce-mcmath bryce-mcmath deleted the feat/android-attestation-support branch November 8, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants