feat: refresh pool on connect #1576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wadeking98 <[email protected]>
Signed-off-by: wadeking98 <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
@wadeking98 I will test this and see what it looks like at the firewall level where I can monitor network connections. You might be able to do this also on your linux laptop with wireshark - not sure. I think Wade B made the comment we probably only want to rebuild / reconcile the pool infrequently. He was thinking no more than every 24h. But, if this is not an overly slow process we can keep it as an interim step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a patch to refresh the pool when connecting, solves the slowness issue with lsbc credential
together with: openwallet-foundation/bifold-wallet#1015 this should speed up the wallet quite a bit