Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update onboarding, add in preface scrn #1573

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Conversation

bryce-mcmath
Copy link
Contributor

@bryce-mcmath bryce-mcmath commented Oct 26, 2023

Depends on: openwallet-foundation/bifold-wallet#1010

Here's what the changes look like:
onboarding

I kept the CreatePageWith code structure even though it's only being used once just in case we need to go back and add more onboarding pages later. Open to removing it if that's what the other devs want

@bryce-mcmath bryce-mcmath added the do not merge This PR is on hold. label Oct 26, 2023
Signed-off-by: Bryce McMath <[email protected]>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bryce-mcmath bryce-mcmath marked this pull request as ready for review October 31, 2023 23:31
@bryce-mcmath bryce-mcmath removed the do not merge This PR is on hold. label Oct 31, 2023
@jleach jleach merged commit cab32f3 into main Oct 31, 2023
9 checks passed
@jleach jleach deleted the feat/onboarding-updates branch October 31, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants