Skip to content

Commit

Permalink
chore: upgrade node version used in action (#1596)
Browse files Browse the repository at this point in the history
Signed-off-by: Bryce McMath <[email protected]>
  • Loading branch information
bryce-mcmath authored Nov 10, 2023
1 parent d808c48 commit 5545525
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/actions/setup-node/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ inputs:
node-version:
description: Select the nodejs version to use
required: false
default: "16.15.0"
default: "18.18.2"

runs:
using: composite
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ jobs:
run: |
git submodule update --init --recursive
- uses: actions/setup-python@v4
with:
python-version: '3.11'

- name: Setup NodeJS
uses: ./.github/workflows/actions/setup-node

Expand Down Expand Up @@ -253,6 +257,10 @@ jobs:
run: |
git submodule update --init --recursive
- uses: actions/setup-python@v4
with:
python-version: '3.11'

- name: Setup NodeJS
uses: ./.github/workflows/actions/setup-node

Expand All @@ -271,8 +279,6 @@ jobs:
- name: Install dependencies
working-directory: ./
run: |
rm bifold/package.json && \
rm bifold/yarn.lock && \
yarn install --immutable && \
git status
Expand Down
2 changes: 1 addition & 1 deletion app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"main": "index.js",
"license": "Apache-2.0",
"engines": {
"node": ">=16.15.0 <18.0.0",
"node": ">=18.18.2 <20.0.0",
"yarn": "^3.3.1"
},
"installConfig": {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"private": true,
"license": "Apache-2.0",
"engines": {
"node": ">=16.15.0 <18.0.0",
"node": ">=18.18.2 <20.0.0",
"yarn": "^3.3.1"
},
"packageManager": "[email protected]",
Expand Down

0 comments on commit 5545525

Please sign in to comment.