Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sprint 82 fixes #943

Merged
merged 17 commits into from
Nov 2, 2023
Merged

sprint 82 fixes #943

merged 17 commits into from
Nov 2, 2023

Conversation

ikethecoder
Copy link
Member

@ikethecoder ikethecoder commented Oct 24, 2023 •
edited
Loading

@ikethecoder
Copy link
Member Author

@nirajCITZ When you have some time, go at it for retesting these defects :)

Jonesy
Jonesy previously requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@Jonesy Jonesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes, the error assignment one is optional, but with the operators there's a potential for some values to slip by.

src/services/notification/notification.service.ts Outdated Show resolved Hide resolved
src/services/checkStatus.ts Outdated Show resolved Hide resolved
src/nextapp/components/service-routes/service-routes.tsx Outdated Show resolved Hide resolved
src/nextapp/components/api-product-item/api-product-item.tsx Outdated Show resolved Hide resolved
src/batch/feed-worker.ts Outdated Show resolved Hide resolved
@ikethecoder ikethecoder requested a review from Jonesy November 1, 2023 20:51
@ikethecoder ikethecoder dismissed Jonesy’s stale review November 2, 2023 01:02

All suggested changes have been made

@ikethecoder ikethecoder merged commit 1d11ed5 into dev Nov 2, 2023
3 checks passed
@ikethecoder ikethecoder deleted the feature/sp82-fixes branch November 2, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jTendeck jTendeck jTendeck approved these changes

@Elson9 Elson9 Elson9 approved these changes

@nirajCITZ nirajCITZ Awaiting requested review from nirajCITZ

@Jonesy Jonesy Awaiting requested review from Jonesy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the UX of revoking access and deleting consumer Prevent clients from accidentally using the incomplete ‘Manual’ authorization mode Mark can Grant Access to the service for the environment which is pending for approval Hard delete of Namespace (/namespaces/{ns}?force=true) cause the application inaccessible (throws 502 Bad Gateway Error) Address requestor as Portal User in the Email Notifications when name is not available
When requesting access giving an error that is difficult to troubleshoot Hard delete ( force delete) cause namespace list service fails and does not display namespaces in the drop down Confirm when deleting resources Product without environments giving an error Route not appearing in Portal after creating using v2 of gwa cli
4 participants
@ikethecoder @Jonesy @Elson9 @jTendeck