Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak style for gateway list item hover #1184

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

rustyjux
Copy link
Contributor

@rustyjux rustyjux commented Oct 4, 2024

Follows up on Tim's comment on #1179 - #1179 (review)

I'm wondering if we're able to style the Gateway display name with an underline based on the state of the parent to better match the styling of cards in the Gateways manager:

image

We think the hover background is rather dark but apparently that's the recommendation in the BC design tokens.


🚀 Feature branch deployment: https://api-services-portal-feature-click-gateway-item.apps.silver.devops.gov.bc.ca


🚀 Feature branch deployment: https://api-services-portal-feature-click-gateway-item.apps.silver.devops.gov.bc.ca

@rustyjux rustyjux requested review from Elson9 and timng-bcgov October 4, 2024 18:38
Copy link

@timng-bcgov timng-bcgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, I'm following guidelines for the secondary button component from the Design System. The button doesn't toggle the label colour like we're doing here, but there are no concerns about contrast:
image

We still need to work on the keyboard focus state and semantic identification of the component (use a button or anchor element instead of a div).

@rustyjux
Copy link
Contributor Author

@Elson9 waiting for review

@rustyjux rustyjux merged commit 6b4eb86 into dev Oct 22, 2024
7 checks passed
@rustyjux rustyjux deleted the feature/click-gateway-item branch October 22, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants