-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limits changed to Elevated Access, margin added + copy changed #1010
base: dev
Are you sure you want to change the base?
Conversation
Design wise I think it's a step in the right direction towards clarifying that elevated access is not a separate product. Additional changes to consider:
|
Add in placeholder button |
<AccessRequestForm | ||
disabled={false} | ||
id={id} | ||
name={data.name} | ||
preview={preview} | ||
/> | ||
) : ( | ||
<Button | ||
disabled={true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disabled={true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or rather ={false}
if we keep that attribute around usually
Margin added to prevent two-tiered access from looking like a separate product.
Removed "has a rate limit enforced" as this is not a strict requirement of two-tiered access.
Limits changed to Elevated Access to avoid confusion.
Added text to clarify that public access does not require an API key.
🚀 Feature branch deployment: https://api-services-portal-feature-directory-changes.apps.silver.devops.gov.bc.ca