Add Public Notification View #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dhaselhan
commented
Oct 10, 2023
dhaselhan
commented
- Add public.dto to backend to better match front end structure
- Small cleanups
* Add public.dto to backend to better match front end structure * Small cleanups
dhaselhan
force-pushed
the
feature/ALCS-1176
branch
from
52a0e35 to
d2a7309
Compare
mhuseinov
approved these changes
Oct 10, 2023
| styleUrls: ['./additional-information.component.scss'], | ||
| }) | ||
| export class AdditionalInformationComponent implements OnInit { | ||
| firstQuestion = 'FIX THIS'; |
There was a problem hiding this comment.
I remember seeing this on some other feature. Is it intentional here or copy-paste?
There was a problem hiding this comment.
This is intentional, its a scary placeholder that you will notice if you don't set it properly.
| provide: PublicService, | ||
| useValue: mockPublicService, | ||
| }, | ||
| ], |
There was a problem hiding this comment.
nitpick NO_ERROR_SCHEMA
| expect(service).toBeDefined(); | ||
| }); | ||
|
|
||
| it('load a Notice of Intent and its related data for get NOI', async () => { |
There was a problem hiding this comment.
Looks like a typo. Should be Notification instead of Notice of Intent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.