Base Views for Public Search #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dhaselhan
commented
Sep 25, 2023
dhaselhan
commented
- Add Public Module with Search
- Add new views with public filters
* Add Public Module with Search * Add new views with public filters
mhuseinov
approved these changes
Sep 25, 2023
| searchDto.dateDecidedFrom !== undefined | ||
| ) { | ||
| query = this.joinApplicationDecision(query); | ||
| // TODO |
There was a problem hiding this comment.
I assume this will be addressed in later mrs, correct?
| searchDto: SearchRequestDto, | ||
| query, | ||
| ) { | ||
| if (searchDto.fileTypes.length > 0) { |
There was a problem hiding this comment.
do you need to adjust this code according to the commented out decision code above?
There was a problem hiding this comment.
Maybe, I'm not sure yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.