Return strict boolean from email service

bcgov · May 7, 2024 · ec6143e · ec6143e
1 parent 73224d4
commit ec6143e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 12 deletions.
diff --git a/services/apps/alcs/src/portal/notification-submission/notification-submission.service.ts b/services/apps/alcs/src/portal/notification-submission/notification-submission.service.ts
@@ -409,16 +409,15 @@ export class NotificationSubmissionService {
   ): Promise<boolean> {
     const templateData = await this.generateSrwEmailData(submission, document);
 
-    const didSend =
-      (await this.emailService.sendEmail({
-        to: [templateData.to],
-        body: templateData.html,
-        subject: `Agricultural Land Commission SRW${submission.fileNumber} (${submission.applicant})`,
-        parentType: PARENT_TYPE.NOTIFICATION,
-        parentId: templateData.parentId,
-        cc: templateData.cc,
-        attachments: [document.document],
-      })) ?? false;
+    const didSend = await this.emailService.sendEmail({
+      to: [templateData.to],
+      body: templateData.html,
+      subject: `Agricultural Land Commission SRW${submission.fileNumber} (${submission.applicant})`,
+      parentType: PARENT_TYPE.NOTIFICATION,
+      parentId: templateData.parentId,
+      cc: templateData.cc,
+      attachments: [document.document],
+    });
 
     if (didSend) {
       const fileBuffer = Buffer.from(templateData.html);

diff --git a/services/apps/alcs/src/providers/email/email.service.ts b/services/apps/alcs/src/providers/email/email.service.ts
@@ -102,7 +102,7 @@ export class EmailService {
     parentId?: string;
     triggerStatus?: string;
     attachments?: Document[];
-  }) {
+  }): Promise<boolean> {
     const serviceUrl = this.config.get<string>('CHES.URL');
     const from = this.config.get<string>('CHES.FROM');
     const token = await this.getToken();
@@ -134,7 +134,7 @@ export class EmailService {
           { to, body, subject, cc, bcc },
           'EmailService did not send the email. Set CHES.MODE to production if you need to send an email.',
         );
-        return;
+        return false;
       }
       const res = await firstValueFrom(
         this.httpService.post<{