use conditional function to add and remove tags

bcgov · Nov 12, 2024 · 8af844d · 8af844d
1 parent defad5f
commit 8af844d
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/services/apps/alcs/src/portal/application-submission/application-submission.service.ts b/services/apps/alcs/src/portal/application-submission/application-submission.service.ts
@@ -1125,16 +1125,11 @@ export class ApplicationSubmissionService {
 
     for (const structureTag of structureTags) {
       try {
-        const tagExists = await this.applicationTagService.applicationHasTag(
+        await this.conditionallyApplyTag(
           applicationSubmission.fileNumber,
+          structureTypes.has(structureTag),
           structureTag,
         );
-
-        if (!structureTypes.has(structureTag) && tagExists) {
-          await this.applicationTagService.removeTagFromApplication(applicationSubmission.fileNumber, structureTag);
-        } else if (structureTypes.has(structureTag) && !tagExists) {
-          await this.applicationTagService.addTagToApplication(applicationSubmission.fileNumber, structureTag);
-        }
       } catch (e) {
         this.logger.error(
           `Could not conditionally add tag ${structureTag} to application number ${applicationSubmission.fileNumber} with error: ${e.error}`,