Merge pull request #1977 from bcgov/bugfix/ALCS-2373-fix

Apply last PFRS change to POFO/ROSO
bcgov · Nov 13, 2024 · 609737d · 609737d
2 parents b010b59 + d1c2281
commit 609737d
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/...p/features/applications/edit-submission/proposal/pofo-proposal/pofo-proposal.component.ts b/...p/features/applications/edit-submission/proposal/pofo-proposal/pofo-proposal.component.ts
@@ -347,7 +347,7 @@ export class PofoProposalComponent extends FilesStepComponent implements OnInit,
 
     this.structuresSource = new MatTableDataSource(this.proposedStructures);
 
-    if (this.hasInput(structure.type, newType)) {
+    if (this.structureChangeRequiresConfirmation(structure.type, newType)) {
       this.confirmationDialogService
         .openDialog({
           title: 'Change Structure Type',
@@ -382,7 +382,7 @@ export class PofoProposalComponent extends FilesStepComponent implements OnInit,
     this.form.markAsDirty();
   }
 
-  private hasInput(oldType: STRUCTURE_TYPES | null, newType: STRUCTURE_TYPES | null) {
+  private structureChangeRequiresConfirmation(oldType: STRUCTURE_TYPES | null, newType: STRUCTURE_TYPES | null) {
     const residentialTypes = [
       STRUCTURE_TYPES.PRINCIPAL_RESIDENCE,
       STRUCTURE_TYPES.ADDITIONAL_RESIDENCE,
@@ -392,14 +392,15 @@ export class PofoProposalComponent extends FilesStepComponent implements OnInit,
     const changingToResidentialType = newType && residentialTypes.includes(newType);
 
     return !!(
-      (oldType &&
+      oldType !== newType &&
+      ((oldType &&
         oldType === STRUCTURE_TYPES.FARM_STRUCTURE &&
         (this.soilAgriParcelActivity.value || this.soilStructureFarmUseReason.value)) ||
-      (changingFromResidentialType && !changingToResidentialType && this.soilStructureResidentialUseReason.value) ||
-      (oldType &&
-        oldType === STRUCTURE_TYPES.ACCESSORY_STRUCTURE &&
-        this.soilStructureResidentialAccessoryUseReason.value) ||
-      (oldType && oldType === STRUCTURE_TYPES.OTHER_STRUCTURE && this.soilStructureOtherUseReason.value)
+        (changingFromResidentialType && !changingToResidentialType && this.soilStructureResidentialUseReason.value) ||
+        (oldType &&
+          oldType === STRUCTURE_TYPES.ACCESSORY_STRUCTURE &&
+          this.soilStructureResidentialAccessoryUseReason.value) ||
+        (oldType && oldType === STRUCTURE_TYPES.OTHER_STRUCTURE && this.soilStructureOtherUseReason.value))
     );
   }
 

diff --git a/...p/features/applications/edit-submission/proposal/roso-proposal/roso-proposal.component.ts b/...p/features/applications/edit-submission/proposal/roso-proposal/roso-proposal.component.ts
@@ -456,7 +456,7 @@ export class RosoProposalComponent extends FilesStepComponent implements OnInit,
 
     this.structuresSource = new MatTableDataSource(this.proposedStructures);
 
-    if (this.hasInput(structure.type, newType)) {
+    if (this.structureChangeRequiresConfirmation(structure.type, newType)) {
       this.confirmationDialogService
         .openDialog({
           title: 'Change Structure Type',
@@ -491,7 +491,7 @@ export class RosoProposalComponent extends FilesStepComponent implements OnInit,
     this.form.markAsDirty();
   }
 
-  private hasInput(oldType: STRUCTURE_TYPES | null, newType: STRUCTURE_TYPES | null) {
+  private structureChangeRequiresConfirmation(oldType: STRUCTURE_TYPES | null, newType: STRUCTURE_TYPES | null) {
     const residentialTypes = [
       STRUCTURE_TYPES.PRINCIPAL_RESIDENCE,
       STRUCTURE_TYPES.ADDITIONAL_RESIDENCE,
@@ -501,7 +501,8 @@ export class RosoProposalComponent extends FilesStepComponent implements OnInit,
     const changingToResidentialType = newType && residentialTypes.includes(newType);
 
     return !!(
-      (oldType &&
+      (oldType !== newType &&
+        oldType &&
         oldType === STRUCTURE_TYPES.FARM_STRUCTURE &&
         (this.soilAgriParcelActivity.value || this.soilStructureFarmUseReason.value)) ||
       (changingFromResidentialType && !changingToResidentialType && this.soilStructureResidentialUseReason.value) ||