PSP-9794 : Acquisition Files - Team Members: Select contact button lo… #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oks misaligned when chosen Acquisition Team is and organization with more than 1 individual contact attach to it
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4591 |
asanchezr
reviewed
Jan 13, 2025
Comment on lines
45
to
52
| span { | ||
| display: contents; | ||
| text-overflow: ellipsis; | ||
| overflow: hidden; | ||
| display: -webkit-box; | ||
| -webkit-line-clamp: 2; | ||
| line-clamp: 2; | ||
| -webkit-box-orient: vertical; |
There was a problem hiding this comment.
did we check this styling? a couple things I see:
- there are 2 declarations of
"display: contents"and"display: -webkit-box"- seems odd -webkit-box-orient: verticalis deprecated and should not be used. According to https://developer.mozilla.org/en-US/docs/Web/CSS/box-orient
There was a problem hiding this comment.
Updated, also I don't believe box-orient and webkit-box-orient are the same.
asanchezr
approved these changes
Jan 13, 2025
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4591 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4591 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oks misaligned when chosen Acquisition Team is and organization with more than 1 individual contact attach to it