Address race condition where: (see comment) #4559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
devinleighsmith
commented
Dec 30, 2024
•
devinleighsmith
commented
- (process 1) upload document action starts upload, sets document to processing
- (process 2) document poll starts executing with document in processing state
- (process 1) upload document action completes upload, sets document to sucess.
- (process 2) document poll throws concurrency exception.
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4559 |
devinleighsmith
changed the title
asanchezr
approved these changes
Dec 30, 2024
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4559 |
devinleighsmith
force-pushed
the
race_condition
branch
from
f584615 to
55f5dec
Compare
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4559 |
1) (thread #1) upload document action starts upload, sets document to processing 2) (thread #2) document poll starts executing with document in processing state 3) (thread #1) upload document action completes upload, sets document to sucess. 4) (thread #2) document poll throws concurrency exception.
devinleighsmith
force-pushed
the
race_condition
branch
from
55f5dec to
c9e51cf
Compare
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4559 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.