-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Psp 9512 jobs for upload, polling, retries #4529
Conversation
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4529 |
1 similar comment
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4529 |
759e762
to
74bfee3
Compare
…recent copy of documentQueue -> since polling may trigger updates.
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4529 |
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4529 |
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4529 |
/// </summary> | ||
/// <returns></returns> | ||
[HttpGet("{documentQueueId:long}")] | ||
[HasPermission(Permissions.SystemAdmin)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general question about permissions - I see all queue endpoints require sysadmin permissions. Is this intended? How will the frontend connect to this new API for non-admin users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the frontend won't connect to this api, at least, not directly. The documents will come in from the frontend via the document controller, which will handle adding the document queue entity. This controller that allows direct interaction with the document queue is really only used by the scheduler.
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4529 |
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4529 |
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4529 |
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4529 |
1 similar comment
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4529 |
No description provided.