PSP-9561 Update release GHA to support deployments #4503
Conversation
| shell: bash | ||
| run: | | ||
| oc process -f ./openshift/s2i/nginx-runtime/nginx-runtime.yaml -p GIT_REF=${{github.event.inputs.HOTFIX_BRANCH}} -p OUTPUT_IMAGE_TAG="latest-${{github.event.inputs.HOTFIX_BRANCH}}" | oc create --selector ci_cd=true -f - | ||
| oc process -f ./openshift/4.0/templates/api/build.yaml -p GIT_REF=${{github.event.inputs.HOTFIX_BRANCH}} -p OUTPUT_IMAGE_TAG="latest-${{github.event.inputs.HOTFIX_BRANCH}}" | oc create --selector ci_cd=true -f - |
There was a problem hiding this comment.
We would also need a create builds for the new microservices for this to work (or there won't be a correctly named build for the proxy to run). Options here are:
- add a build.yaml for the proxy and then add a section here to create that build, same as the others.
- disable this GHA for now, as we always hold UAT until after release these days.
There was a problem hiding this comment.
This action is for the weird case of a UAT hotfix where we are holding UAT to release to PROD (I think).
The most used UAT hotfix action is the other one (named uat-hotfix.yaml). I think Devin knows the difference.
This would need to be modified in the near future
There was a problem hiding this comment.
I think I am going to disable this GHA for now and log tech debt to address this. Otherwise the rest of the changes would be waiting for that. As you said - this is not often used.
| - name: Call script to build frontend (pims-app and pims-app-base) | ||
| run: | | ||
| ./openshift/4.0/player.sh build app-base -apply | ||
| ./openshift/4.0/player.sh build app -apply |
There was a problem hiding this comment.
You'll need to build the proxy as well (that is in my PR for the scheduler microservice).
There was a problem hiding this comment.
The proxy DOES get built in the next step (bundled with the API build). This step is for the frontend. Did I miss something else?
| run: | | ||
| VERSION=$(make version) | ||
| oc tag pims-app:uat pims-app:v${VERSION}-master | ||
| oc tag pims-api:uat pims-api:v${VERSION}-master |
There was a problem hiding this comment.
also need a tag here for the proxy.
There was a problem hiding this comment.
Good catch. Fixed there and in the retag GHA from test to uat
There was a problem hiding this comment.
Also needed to add a tag for mayan here
asanchezr
force-pushed
the
psp-9561-gha-deployment-updates
branch
from
87466c9 to
5c73a71
Compare
No description provided.