PSP-9451 : Lease/ Licence- Filters section-Separate PID and PIN in th… #4472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Search by section
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4472 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4472 |
1 similar comment
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4472 |
|
|
||
| if (!string.IsNullOrWhiteSpace(filter.Pin)) | ||
| { | ||
| var pinValue = filter.Pin.Replace("-", string.Empty).Trim().TrimStart('0'); |
There was a problem hiding this comment.
A pins shouldn't have any hyphens, was there a reason for this?
There was a problem hiding this comment.
I wasn't sure about the PIN format but this is how it was handled before.
devinleighsmith
approved these changes
Nov 18, 2024
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4472 |
1 similar comment
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4472 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e Search by section