split off geoserver functionality into a microservice - update docker… #4427
Conversation
|
Please don't review until after 5.6 functionality is complete |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
1 similar comment
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
.github/workflows/ci-cd-pims-dev.yml
Outdated
| pull_request_target: | ||
| branches: [dev] | ||
| types: [closed] |
There was a problem hiding this comment.
I like this change but it will lead to a change in our process. From now on, developers will be responsible to trigger the CI build for DEV environment themselves, right?
We should talk about how would that look like within the team
| @@ -1 +0,0 @@ | |||
| DOTNET_STARTUP_PROJECT=api/Pims.Api.csproj | |||
There was a problem hiding this comment.
I think this file is used as part of openshift building .NET
Did you test this change in openshift?
source/backend/Dockerfile.proxy
Outdated
| COPY entrypoint.sh . | ||
| RUN chmod +x /app/entrypoint.proxy.sh | ||
| ENTRYPOINT ["/app/entrypoint.proxy.sh"] |
There was a problem hiding this comment.
Can you check that we are copying the right file?
COPY entrypoint.proxy.sh .
# instead of entrypoint.sh which does not exist on this folder?
|
|
||
| /// <summary> | ||
| /// Parses the environment configuration and returns 'JsonSerializerOptions'. | ||
| /// </summary> | ||
| /// <param name="configuration"></param> | ||
| /// <returns></returns> | ||
| public static JsonSerializerOptions GenerateJsonSerializerOptions(this IConfiguration configuration) | ||
| { | ||
| return new JsonSerializerOptions() | ||
| { | ||
| DefaultIgnoreCondition = (!string.IsNullOrWhiteSpace(configuration["Serialization:Json:IgnoreNullValues"]) && bool.Parse(configuration["Serialization:Json:IgnoreNullValues"])) ? JsonIgnoreCondition.WhenWritingNull : JsonIgnoreCondition.Never, | ||
| PropertyNameCaseInsensitive = !string.IsNullOrWhiteSpace(configuration["Serialization:Json:PropertyNameCaseInsensitive"]) && bool.Parse(configuration["Serialization:Json:PropertyNameCaseInsensitive"]), | ||
| PropertyNamingPolicy = configuration["Serialization:Json:PropertyNamingPolicy"] == "CamelCase" ? JsonNamingPolicy.CamelCase : null, | ||
| WriteIndented = !string.IsNullOrWhiteSpace(configuration["Serialization:Json:WriteIndented"]) && bool.Parse(configuration["Serialization:Json:WriteIndented"]), | ||
| Converters = { new JsonStringEnumMemberConverter(JsonNamingPolicy.CamelCase) }, | ||
| ReferenceHandler = ReferenceHandler.IgnoreCycles, | ||
| }; | ||
| } |
There was a problem hiding this comment.
I'm guessing this was dead-code?
| @@ -1,4 +1,6 @@ | |||
| using Pims.Core.Security; | |||
There was a problem hiding this comment.
nit: github is complaining here about linting. perhaps need to sort the using statements
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
10 similar comments
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
devinleighsmith
force-pushed
the
geoserver_microservice
branch
from
1438a5c to
681b338
Compare
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
1 similar comment
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4427 |
… and ci/cd to support.