PSP-7414 Tech debt: Remove obsolete roles from PSP frontend #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3718 +/- ##
==========================================
- Coverage 74.91% 73.84% -1.07%
==========================================
Files 1439 947 -492
Lines 37184 20370 -16814
Branches 6973 5864 -1109
==========================================
- Hits 27855 15042 -12813
+ Misses 9051 5328 -3723
+ Partials 278 0 -278
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Comment on lines
38
to
42
| } else if ( | ||
| keyCloakWrapper.roles?.length === 1 && | ||
| keyCloakWrapper.hasRole(Roles.LEASE_FUNCTIONAL) | ||
| ) { |
There was a problem hiding this comment.
this looked like a bug waiting to be found
FuriousLlama
approved these changes
Jan 17, 2024
asanchezr
force-pushed
the
psp-7414-tech-debt
branch
from
3b517ed to
7c8de37
Compare
|
✅ No secrets were detected in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.