Updated Document Upload and details #3643
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| import { ChangeEvent, FunctionComponent, useState } from 'react'; | ||
| import styled from 'styled-components'; | ||
|
|
||
| import { SectionField } from '../Section/SectionField'; | ||
|
|
||
| interface IFileDragAndDropProps { | ||
| onSelectFile: (file: File | null) => void; | ||
| selectedFile: File | null; | ||
| validExtensions: string[]; | ||
| } | ||
|
|
||
| const FileDragAndDrop: FunctionComponent<React.PropsWithChildren<IFileDragAndDropProps>> = ({ | ||
|
There was a problem hiding this comment. The test coverage on this isn't great. Unit testing this completely may not be realistic but is there anything we can do here? |
||
| onSelectFile, | ||
| selectedFile, | ||
| validExtensions, | ||
| }) => { | ||
| const validDocumentExtensions: string = validExtensions.map(x => `.${x}`).join(','); | ||
|
|
||
| const [isDragging, setIsDragging] = useState(false); | ||
|
|
||
| const handleFileInput = (changeEvent: ChangeEvent<HTMLInputElement>) => { | ||
| // handle validations | ||
| if (changeEvent.target !== null) { | ||
| var target = changeEvent.target; | ||
| if (target.files !== null) { | ||
|
There was a problem hiding this comment. target.files?.length !== null & target.files.length >= 1 There was a problem hiding this comment. sure, added the check for at least one file |
||
| onSelectFile(target.files[0]); | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| const handleDragEnter = (event: React.DragEvent) => { | ||
| event.preventDefault(); | ||
| event.stopPropagation(); | ||
|
|
||
| setIsDragging(true); | ||
| }; | ||
|
|
||
| const handleDragLeave = (event: React.DragEvent) => { | ||
| event.preventDefault(); | ||
| event.stopPropagation(); | ||
|
|
||
| setIsDragging(false); | ||
| }; | ||
|
|
||
| const handleDragOver = (event: React.DragEvent) => { | ||
| event.preventDefault(); | ||
| event.stopPropagation(); | ||
|
|
||
| setIsDragging(true); | ||
| }; | ||
|
|
||
| const handleDrop = (event: React.DragEvent) => { | ||
| event.preventDefault(); | ||
| event.stopPropagation(); | ||
|
|
||
| let files = [...event.dataTransfer.files]; | ||
|
|
||
| if (files && files.length > 0) { | ||
| onSelectFile(files[0]); | ||
| event.dataTransfer.clearData(); | ||
| } | ||
|
|
||
| setIsDragging(false); | ||
| }; | ||
|
|
||
| const shortenString = (text: string, maxlenght: number, terminator: string = '...'): string => { | ||
|
There was a problem hiding this comment. maxlenght -> maxLength |
||
| if (text.length > maxlenght) { | ||
| return text.substring(0, maxlenght - terminator.length) + terminator; | ||
| } | ||
|
|
||
| return text; | ||
| }; | ||
|
|
||
| return ( | ||
| <div> | ||
| <DragDropZone | ||
| onDrop={handleDrop} | ||
| onDragOver={handleDragOver} | ||
| onDragEnter={handleDragEnter} | ||
| onDragLeave={handleDragLeave} | ||
| isDragging={isDragging} | ||
| > | ||
| <StyledContent> | ||
| Drag files here to attach or{' '} | ||
| <StyledUploadLabel> | ||
| Browse | ||
| <StyledFileInput | ||
| data-testid="upload-input" | ||
| id="uploadInput" | ||
| type="file" | ||
| name="documentFile" | ||
| accept={validDocumentExtensions} | ||
| onChange={handleFileInput} | ||
| className="" | ||
| /> | ||
| </StyledUploadLabel> | ||
| </StyledContent> | ||
| </DragDropZone> | ||
| {selectedFile !== null && ( | ||
| <StyledSelectedFile> | ||
| <SectionField label="File to add" labelWidth="3"> | ||
| {shortenString(selectedFile.name || '', 20)} | ||
|
There was a problem hiding this comment. maybe could use the OverflowTip component instead? There was a problem hiding this comment. I checked with ana and this way worked better |
||
| </SectionField> | ||
| </StyledSelectedFile> | ||
| )} | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default FileDragAndDrop; | ||
|
|
||
| const DragDropZone = styled.div<{ isDragging: boolean }>` | ||
| border: 1px solid ${({ theme }) => theme.css.lightVariantColor}; | ||
|
|
||
| border-style: ${({ isDragging }) => (isDragging ? 'solid' : 'dashed')}; | ||
|
|
||
| border: ${props => (props.isDragging ? `1px solid ${props.theme.css.draftColor}` : '')}; | ||
|
|
||
| background-color: ${props => (props.isDragging ? props.theme.css.filterBoxColor : '')}; | ||
|
|
||
| height: 10rem; | ||
| line-height: 10rem; | ||
| text-align: center; | ||
| `; | ||
|
|
||
| const StyledContent = styled.div` | ||
| width: 100%; | ||
| display: inline-block; | ||
| vertical-align: middle; | ||
| line-height: normal; | ||
| `; | ||
|
|
||
| const StyledUploadLabel = styled.label` | ||
| display: inline-block; | ||
| color: ${({ theme }) => theme.css.linkColor}; | ||
| cursor: pointer; | ||
|
|
||
| &:hover { | ||
| color: ${({ theme }) => theme.css.linkHoverColor}; | ||
| text-decoration: underline; | ||
| } | ||
| `; | ||
|
|
||
| const StyledFileInput = styled.input` | ||
| display: none; | ||
| `; | ||
|
|
||
| const StyledSelectedFile = styled.div` | ||
| padding-top: 2rem; | ||
| overflow: hide; | ||
| word-wrap: break-word; | ||
| `; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already have the title property to get the buttons in tests. not opposed to adding test ids but I believe the right syntax is data-testid="..."
See here: https://testing-library.com/docs/queries/bytestid/