psp-7346 correct bracket usage, ensure logic limited to file close only. #3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ No secrets were detected in the code. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev #3622 +/- ##
==========================================
- Coverage 69.51% 63.43% -6.09%
==========================================
Files 1375 474 -901
Lines 34403 15416 -18987
Branches 6496 1059 -5437
==========================================
- Hits 23916 9779 -14137
+ Misses 10227 5376 -4851
- Partials 260 261 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -242,7 +242,7 @@ public PimsAcquisitionFile Update(PimsAcquisitionFile acquisitionFile, IEnumerab | |||
|
|
|||
| _user.ThrowInvalidAccessToAcquisitionFile(_userRepository, _acqFileRepository, acquisitionFile.Internal_Id); | |||
| ValidateVersion(acquisitionFile.Internal_Id, acquisitionFile.ConcurrencyControlNumber); | |||
| ValidateDrafts(acquisitionFile.Internal_Id); | |||
| ValidateDrafts(acquisitionFile); | |||
There was a problem hiding this comment.
kinda of a nit: The current acq file is being retrieved multiple times for each validation function, ideally we would retrieve it once and pass it to the validation logic
There was a problem hiding this comment.
Hmm, I only see one request for the acquisition file in any validate functions within Update:
ValidatePayeeDependency
the only other call is at the end of the update function, but that is after the transaction is committed so I think that makes sense.
There was a problem hiding this comment.
for example teh GetCurrentAcquisitionStatus will retrieve the latest acq file for the given id
| @@ -948,7 +949,7 @@ private void ValidateInterestHoldersDependency(long acquisitionFileId, List<Pims | |||
| var currentAcquisitionFile = _acqFileRepository.GetById(acquisitionFileId); | |||
| AcquisitionStatusTypes currentAcquisitionStatus; | |||
|
|
|||
| if (Enum.TryParse(currentAcquisitionFile.AcquisitionFileStatusTypeCode, out currentAcquisitionStatus)) | |||
| if (Enum.TryParse(currentAcquisitionFile?.AcquisitionFileStatusTypeCode, out currentAcquisitionStatus)) | |||
There was a problem hiding this comment.
the acq file should never be null here.
There was a problem hiding this comment.
imo, having the code throw here if null is a good idea
devinleighsmith
force-pushed
the
psp-7346
branch
from
44dc8f7 to
247f20e
Compare
|
✅ No secrets were detected in the code. |
2 similar comments
|
✅ No secrets were detected in the code. |
|
✅ No secrets were detected in the code. |
FuriousLlama
approved these changes
Dec 2, 2023
devinleighsmith
force-pushed
the
psp-7346
branch
from
f3336d5 to
49b1d24
Compare
|
✅ No secrets were detected in the code. |
FuriousLlama
added a commit
that referenced
this pull request
Dec 7, 2023
* Added check status logic when updating acq and related entities | psp-7006 (#3602) * Added status checking to details, take, compensation and other acq file pages * Updated backend and updated tests * Fixed lint * Refactored solver to be simpler * Added tests * Pr comments * Added the sys-admin to edit acquisition fields * CI: Bump version to v4.0.0-67.24 * Updated placeholder display (#3620) * CI: Bump version to v4.0.0-67.25 * dialog correction. (#3629) Co-authored-by: Smith <[email protected]> * CI: Bump version to v4.0.0-67.26 * Keycloak Refactor (#3624) * Refactored keycloak sync to use the keycloak repository used by the API. ALso removed tools.Core and removed redundant models * pr fixes * CI: Bump version to v4.0.0-67.27 * System error modal | psp-7304 (#3628) * Updated Generic modal to use a variant * Improved System error modal * Lit fixes * Info fixes * CI: Bump version to v4.0.0-67.28 * psp-7346 correct bracket usage, ensure logic limited to file close only. (#3622) * psp-7346 correct bracket usage, ensure logic limited to file close only. * comment from code review. * test correction. --------- Co-authored-by: Smith <[email protected]> * CI: Bump version to v4.0.0-67.29 * requested source marked as nullable for validation. (#3630) Co-authored-by: Smith <[email protected]> * CI: Bump version to v4.0.0-67.30 * allow showing the edit screen for management activity while the popout is open. (#3632) Co-authored-by: Smith <[email protected]> * CI: Bump version to v4.0.0-67.31 * Pims api to Frontend ts generator and generated files (#3618) * Refactored concept models. Created a new library and cleaned dependencies between projects. Cleaned names of reused concepts and standarized concept namespace. Cleaned extension and help files * Fixed lints * Initial generator work * Cleaned up files and improved translation * Updated namespaces and path for the api models * Updated generator and cleaned up code * Added make command to generate ts api files and lint them. * First generation of the pims api. * Cleaned up generator and handled generic types. Improved header docks. * Fixed solution * Updated models for keycloak sync and fixed lint warnings * Fixed registering mappers * CI: Bump version to v4.0.0-67.32 * Bump DEV version - IS68 (#3636) * CI: Bump version to v4.0.0-68.1 * Manual merges and re-generated snaps * moved disposition models to the new api-models project * re-generated api models * Changed disposition property to property model type --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: devinleighsmith <[email protected]> Co-authored-by: Smith <[email protected]> Co-authored-by: Alejandro Sanchez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.