Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UAT release - IS66 #3582

Closed
wants to merge 129 commits into from
Closed

UAT release - IS66 #3582

wants to merge 129 commits into from

Conversation

asanchezr
Copy link
Collaborator

No description provided.

stairaku and others added 30 commits October 12, 2023 09:57
* Digital Documents refactoring

* Research File uncomment steps

* Digital Documents refactoring

* Research File uncomment steps

* Refactoring on Wait() method

* Refactoring on Wait() method

* Calibrating previous Waits refactoring for all test cases to run successfully

* Calibrating previous Waits refactoring for all test cases to run successfully

* Acquisition File - Checklist

* Acquisition File refactoring and Stakeholders

* Acquisition Files Stakeholders

* Acquisition Files - Compensation Requisition, Changing Digital Documents - Upload test documents

* Testing queries update

* Leases Refactoring

* Refactoring on Automation - Verify Views, Reserach Files

---------

Co-authored-by: devinleighsmith <[email protected]>
Co-authored-by: Alejandro Sanchez <[email protected]>
* psp-6836 increase reliability of address search matching for properties with pids.

* test corrections.

---------

Co-authored-by: Alejandro Sanchez <[email protected]>
* Fix keycloak sync in github action

* Fix node 12 warning in GHA
* IS-65.00 Database Schema

PSP_PIMS S65.00 Sprint 64 2023-Oct-12
- Added tables:
  - PIMS_PROP_MGMT_ACTIVITY_SUBTYPE
  - PIMS_ACQUISITION_FILE_TEAM_HIST
  - PIMS_PROP_PROP_ACTIVITY_HIST
  - PIMS_PROP_ACT_INVOLVED_PARTY
  - PIMS_PROP_ACT_MIN_CONTACT
  - PIMS_PROP_ACT_MIN_CONTACT_HIST
  - PIMS_PROP_MGMT_ACTIVITY_TYPE
  - PIMS_PROP_MGMT_ACTIVITY_STATUS_TYPE
  - PIMS_PROPERTY_ACTIVITY_INVOICE_HIST
  - PIMS_ACQ_FL_TEAM_PROFILE_TYPE
  - PIMS_ACQUISITION_FILE_TEAM
  - PIMS_PROPERTY_ACTIVITY_INVOICE
  - PIMS_PROPERTY_ACTIVITY
  - PIMS_PROP_PROP_ACTIVITY
  - PIMS_PROP_ACT_INVOLVED_PARTY_HIST
- Altered tables:
  - PIMS_ACQUISITION_FILE_NOTE
  - PIMS_PROPERTY_RESEARCH_FILE_HIST
  - PIMS_PROPERTY_ORGANIZATION
  - PIMS_PROP_INTHLDR_INTEREST_TYPE
  - PIMS_USER_ORGANIZATION
  - PIMS_PROP_PROP_PURPOSE_HIST
  - PIMS_ORGANIZATION_ADDRESS
  - PIMS_PERSON_ADDRESS
  - PIMS_INTHLDR_PROP_INTEREST_HIST
  - PIMS_LEASE_NOTE_HIST
  - PIMS_ACQUISITION_FILE_FORM_HIST
  - PIMS_PROP_PROP_ROAD_TYPE
  - PIMS_REGION_USER
  - PIMS_PROPERTY_HIST
  - PIMS_PERSON_ORGANIZATION_HIST
  - PIMS_ACQUISITION_FILE_DOCUMENT_HIST
  - PIMS_LEASE_DOCUMENT
  - PIMS_PRODUCT
  - PIMS_PROJECT_NOTE_HIST
  - PIMS_PROPERTY_ACQUISITION_FILE
  - PIMS_LEASE_NOTE
  - PIMS_PROJECT_NOTE
  - PIMS_PERSON_HIST
  - PIMS_COMPENSATION_REQUISITION
  - PIMS_PROP_PROP_PURPOSE
  - PIMS_RESEARCH_FILE_NOTE
  - PIMS_PROPERTY
  - PIMS_PRODUCT_HIST
  - PIMS_PERSON_ORGANIZATION
  - PIMS_RESEARCH_FILE_PROJECT
  - PIMS_ACQUISITION_FILE_DOCUMENT
  - PIMS_PROPERTY_RESEARCH_FILE
  - PIMS_USER_ORGANIZATION_HIST
  - PIMS_COMPENSATION_REQUISITION_HIST
  - PIMS_RESEARCH_FILE_DOCUMENT_HIST
  - PIMS_RESEARCH_FILE_PROJECT_HIST
  - PIMS_REGION_USER_HIST
  - PIMS_PROJECT_DOCUMENT
  - PIMS_PROP_PROP_TENURE_TYPE
  - PIMS_PERSON
  - PIMS_PROPERTY_CONTACT_HIST
  - PIMS_PROPERTY_CONTACT
  - PIMS_ACQUISITION_FILE_FORM
  - PIMS_ACQUISITION_FILE_NOTE_HIST
  - PIMS_PROP_PROP_ANOMALY_TYPE
  - PIMS_PROPERTY_ACQUISITION_FILE_HIST
  - PIMS_PROPERTY_ACTIVITY_HIST
  - PIMS_ORGANIZATION_ADDRESS_HIST
  - PIMS_RESEARCH_FILE_DOCUMENT
  - PIMS_LEASE_DOCUMENT_HIST
  - PIMS_PERSON_ADDRESS_HIST
  - PIMS_PROJECT_DOCUMENT_HIST
  - PIMS_INTHLDR_PROP_INTEREST
  - PIMS_PROPERTY_ORGANIZATION_HIST
  - PIMS_RESEARCH_FILE_NOTE_HIST
- Dropped tables:
  - PIMS_PROPERTY_TAX_REMIT_TYPE
  - PIMS_PROPERTY_TAX
  - PIMS_ACQ_FL_PERSON_PROFILE_TYPE
  - PIMS_PROPERTY_PROPERTY_SERVICE_FILE
  - PIMS_PROPERTY_EVALUATION_HIST
  - PIMS_ACQUISITION_FILE_PERSON_HIST
  - PIMS_ACQUISITION_FILE_PERSON
  - PIMS_PROPERTY_TAX_HIST
  - PIMS_PROPERTY_SERVICE_FILE
  - PIMS_PROPERTY_EVALUATION
  - PIMS_PROPERTY_PROPERTY_SERVICE_FILE_HIST
  - PIMS_PROPERTY_SERVICE_FILE_HIST
  - PIMS_PROPERTY_SERVICE_FILE_TYPE
- Added seed scripts:
  - 093_DML_PIMS_ACQ_FL_TEAM_PROFILE_TYPE.sql
  - 134_DML_PIMS_PROP_MGMT_ACTIVITY_STATUS_TYPE.sql
  - 135_DML_PIMS_PROP_MGMT_ACTIVITY_TYPE.sql
  - 136_DML_PIMS_PROP_MGMT_ACTIVITY_SUBTYPE.sql
- Dropped seed scripts:
  - 093_DML_PIMS_ACQ_FL_PERSON_PROFILE_TYPE.sql
- Added test scripts:
  - 056_PIMS_PROP_ACT_MIN_CONTACT.sql
  - 051_PIMS_PROPERTY_ACTIVITY.sql
  - 052_PIMS_PROPERTY_ACTIVITY_INVOICE.sql
  - 053_PIMS_PROP_ACT_MIN_CONTACT.sql
  - 054_PIMS_PROP_ACT_INVOLVED_PARTY.sql
  - 055_PIMS_PROP_PROP_ACTIVITY.sql
- Requires additional metadata to meet standards

* IS-65.00 Refresh

* Update to LATEST Folder

006_PSP_PIMS_PMBC_INDICES.sql

* IS-65.00 Seed Script Removal After Reset

* Refreshed Test Data Scripts

* Fixed pims user

---------

Co-authored-by: Manuel Rodriguez <[email protected]>
* Regenerated scaffold and cleaned up backend and frontend

* PR fixes
* cleanup unused backend code.

* remove tests related to unused code.
…ties. Also correct performance. (#3523)

Co-authored-by: Smith <[email protected]>
* make display of generation button conditional on type of lease.

* test corrections.

---------

Co-authored-by: Smith <[email protected]>
* Allow organizations for acquisition team member.

Update mappings, repository and service class

* Update frontend API models

* Refactor acquisition team to use new contact manager picker

* Create primary contact selector component

* Update form models

* Update acquisition details view

* Update MSW setup

* Test updates

* Update mock lookup codes

* Test updates

* Update snapshots

* Fix failing test

* Fix bug in acquisition list view due to organizations in team members
- 134_DML_PIMS_PROP_MGMT_ACTIVITY_STATUS_TYPE.sql
- 135_DML_PIMS_PROP_MGMT_ACTIVITY_TYPE.sql
- 136_DML_PIMS_PROP_MGMT_ACTIVITY_SUBTYPE.sql

Co-authored-by: Manuel Rodriguez <[email protected]>
* update db-deploy job yaml.

* add build config used to create db-deploy image.

---------

Co-authored-by: Smith <[email protected]>
github-actions bot and others added 17 commits November 7, 2023 00:06
…pdate action definitions to allow for env specific secrets for keycloak sync. (#3573)

* add automatic db deployment to test.

for testing purposes only, revert.

typo.

skip unecessary steps.

temp.

Revert "for testing purposes only, revert."

This reverts commit 629967c.

Revert "skip unecessary steps."

This reverts commit bedc627.

* code review comments.

* test correction.
…e not displayed in the list view until the page is refreshed (#3577)

Co-authored-by: Eduardo Herrera <[email protected]>
* Updated models and added is dedication checks

* Fixed tests
* Updated backend and frontend to allow to reuse products on multiple projects

* Fixed delete flow

* fixed lint

* PR comments and fixes

* Feedback enhancements

* Updated test snaps
* Fix warnings

* Apply PSP-7209 fix to research container
Copy link
Contributor

github-actions bot commented Nov 9, 2023

✅ No secrets were detected in the code.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #3582 (58b2ec2) into test (2f0522e) will decrease coverage by 0.85%.
Report is 3 commits behind head on test.
The diff coverage is 45.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##             test    #3582      +/-   ##
==========================================
- Coverage   70.44%   69.59%   -0.85%     
==========================================
  Files        1341     1371      +30     
  Lines       32369    33865    +1496     
  Branches     6019     6297     +278     
==========================================
+ Hits        22802    23568     +766     
- Misses       9320    10044     +724     
- Partials      247      253       +6     
Flag Coverage Δ
unittests 69.59% <45.25%> (-0.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...end/api/Areas/Admin/Controllers/ClaimController.cs 0.00% <ø> (-100.00%) ⬇️
...kend/api/Areas/Admin/Controllers/RoleController.cs 0.00% <ø> (-100.00%) ⬇️
...DocumentGeneration/DocumentGenerationController.cs 0.00% <ø> (ø)
...api/Areas/Keycloak/Mapping/User/OrganizationMap.cs 100.00% <100.00%> (ø)
...pi/Areas/Projects/Controllers/ProjectController.cs 67.44% <100.00%> (ø)
...Areas/Reports/Controllers/AcquisitionController.cs 0.00% <ø> (ø)
...eas/Research/Controllers/ResearchFileController.cs 0.00% <ø> (ø)
source/backend/api/Controllers/AuthController.cs 0.00% <ø> (ø)
source/backend/api/Controllers/LookupController.cs 100.00% <100.00%> (ø)
source/backend/api/Controllers/TenantController.cs 100.00% <ø> (ø)
... and 72 more

... and 167 files with indirect coverage changes

@asanchezr asanchezr closed this Nov 9, 2023
@asanchezr
Copy link
Collaborator Author

sonar scanner action is failing (probably outdated). will need to re-create the pr and troubleshoot sonar next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants