Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Psp 6991 - organization team support for h0074 and agreements #3553

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Psp 6991 - organization team support for h0074 and agreements #3553

merged 2 commits into from
Oct 31, 2023

Conversation

devinleighsmith
Copy link
Collaborator

No description provided.

@devinleighsmith devinleighsmith added the enhancement New feature or request label Oct 30, 2023
@devinleighsmith devinleighsmith self-assigned this Oct 30, 2023
@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Merging #3553 (2cec851) into dev (b857440) will increase coverage by 5.07%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3553      +/-   ##
==========================================
+ Coverage   69.27%   74.34%   +5.07%     
==========================================
  Files        1370      898     -472     
  Lines       33597    18538   -15059     
  Branches     6238     5231    -1007     
==========================================
- Hits        23274    13782    -9492     
+ Misses      10072     4756    -5316     
+ Partials      251        0     -251
Flag Coverage Δ
unittests 74.34% <77.77%> (+5.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ion/common/GenerateForm/hooks/useGenerateLetter.ts 90.90% <100.00%> (+0.43%) ⬆️
...rce/frontend/src/models/generate/GenerateLetter.ts 100.00% <100.00%> (ø)
...ls/generate/acquisition/GenerateAcquisitionFile.ts 96.36% <93.33%> (-1.32%) ⬇️
.../common/GenerateForm/hooks/useGenerateAgreement.ts 69.62% <60.86%> (-4.63%) ⬇️

... and 472 files with indirect coverage changes

@github-actions
Copy link
Contributor

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith changed the title Psp 6991 Psp 6991 - organization team support for h0074 and agreements Oct 31, 2023
FuriousLlama
FuriousLlama reviewed Oct 31, 2023
View reviewed changes
...ontend/src/features/mapSideBar/acquisition/common/GenerateForm/hooks/useGenerateAgreement.ts
Comment on lines +89 to +91
coordinatorContact: coordinator ?? null,
negotiatingAgent: negotiatingAgent ?? null,
provincialSolicitor: provincialSolicitor ?? null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks cleaner!

@github-actions GitHub Actions
Copy link
Contributor

✅ No secrets were detected in the code.

@devinleighsmith devinleighsmith merged commit 139bc7c into bcgov:dev Oct 31, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FuriousLlama FuriousLlama FuriousLlama approved these changes

Assignees

@devinleighsmith devinleighsmith

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinleighsmith @FuriousLlama