psp-6589 modify acquisition file closing logic for file transfers. Al… #3517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinleighsmith
requested review from
asanchezr,
FuriousLlama,
stairaku,
PryancaJSharma,
eddherrera and
buddy326
as code owners
|
✅ No secrets were detected in the code. |
Codecov Report
@@ Coverage Diff @@
## dev #3517 +/- ##
==========================================
+ Coverage 69.27% 69.31% +0.03%
==========================================
Files 1370 1369 -1
Lines 33623 33611 -12
Branches 6251 6245 -6
==========================================
+ Hits 23292 23297 +5
+ Misses 10080 10063 -17
Partials 251 251
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Snapshot test failed in front end. |
|
✅ No secrets were detected in the code. |
| FileAcquisitionTeam = string.Join(", ", fileProperty.file.PimsAcquisitionFileTeams.Select(x => x.Person.GetFullName(true))), | ||
| FileAcquisitionOwners = string.Join(", ", fileProperty.file.PimsAcquisitionOwners.Select(x => x.FormatOwnerName())), | ||
| }).ToList(); | ||
| .Select(fileProperty => new AcquisitionFileExportModel |
There was a problem hiding this comment.
indentation looks very funky
FuriousLlama
approved these changes
Oct 31, 2023
devinleighsmith
force-pushed
the
psp-6589
branch
from
be9185f to
106de13
Compare
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
psp-6589
branch
from
7b0fdd9 to
46c4157
Compare
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
devinleighsmith
force-pushed
the
psp-6589
branch
from
46c4157 to
a08bffd
Compare
|
✅ No secrets were detected in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…so clean up all unused icons.