Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSP-6824 Property management view #3504

Merged
merged 18 commits into from
Oct 7, 2023

Conversation

asanchezr
Copy link
Collaborator

image

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

✅ No secrets were detected in the code.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #3504 (430887a) into dev (6817697) will increase coverage by 4.05%.
The diff coverage is 86.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3504      +/-   ##
==========================================
+ Coverage   71.24%   75.30%   +4.05%     
==========================================
  Files        1340      877     -463     
  Lines       31955    17774   -14181     
  Branches     6005     4993    -1012     
==========================================
- Hits        22767    13384    -9383     
+ Misses       8941     4390    -4551     
+ Partials      247        0     -247     
Flag Coverage Δ
unittests 75.30% <86.36%> (+4.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tend/src/components/common/MultiselectTextList.tsx 100.00% <100.00%> (ø)
source/frontend/src/components/common/TabView.tsx 100.00% <ø> (ø)
...ilsManagement/detail/PropertyManagementTabView.tsx 66.66% <ø> (ø)
...tail/summary/PropertyManagementDetailContainer.tsx 90.00% <100.00%> (+5.38%) ⬆️
...nt/detail/summary/PropertyManagementDetailView.tsx 100.00% <100.00%> (+28.57%) ⬆️
source/frontend/src/utils/formUtils.ts 81.94% <100.00%> (ø)
source/frontend/src/utils/test-utils.tsx 84.84% <50.00%> (-0.72%) ⬇️
source/frontend/src/utils/propertyUtils.ts 91.48% <75.00%> (-3.39%) ⬇️

... and 464 files with indirect coverage changes

@asanchezr asanchezr force-pushed the psp-6824-management-view branch from 713fd31 to 432bfeb Compare October 6, 2023 00:22
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

✅ No secrets were detected in the code.

@asanchezr asanchezr force-pushed the psp-6824-management-view branch from 432bfeb to ca0d179 Compare October 6, 2023 13:40
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

✅ No secrets were detected in the code.

@asanchezr asanchezr force-pushed the psp-6824-management-view branch from ca0d179 to 1b2f218 Compare October 6, 2023 18:13
@devinleighsmith
Copy link
Collaborator

This is minor, but the spacing seems a bit off the mockup. Can we move the field values a bit more to the left or was this done to be consistent with another screen?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

✅ No secrets were detected in the code.

@devinleighsmith
Copy link
Collaborator

On my screen I'm getting two scroll bars, are you seeing that @asanchezr

image

@asanchezr
Copy link
Collaborator Author

On my screen I'm getting two scroll bars, are you seeing that @asanchezr

image

I did not see this but good catch. This must be a bug within the TAB container not this story but will fix here

@asanchezr
Copy link
Collaborator Author

asanchezr commented Oct 6, 2023

This is minor, but the spacing seems a bit off the mockup. Can we move the field values a bit more to the left or was this done to be consistent with another screen?

I have used the default spacing that comes with the <SectionField /> component - like other forms/views in the app. I would lean towards leaving as is for consistency within the app. Most likely UXpin spacing is not consistent with other forms. Like for example, the property details view uses the same spacing

@asanchezr asanchezr force-pushed the psp-6824-management-view branch from 1b2f218 to 9cae7fd Compare October 6, 2023 19:09
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

✅ No secrets were detected in the code.

@asanchezr asanchezr force-pushed the psp-6824-management-view branch from 9cae7fd to 430887a Compare October 7, 2023 00:20
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

✅ No secrets were detected in the code.

@asanchezr asanchezr merged commit 144fe06 into bcgov:dev Oct 7, 2023
9 checks passed
@asanchezr asanchezr deleted the psp-6824-management-view branch October 7, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants