psp-6864 missing fields required message. #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devinleighsmith
requested review from
asanchezr,
FuriousLlama,
stairaku,
PryancaJSharma,
eddherrera and
buddy326
as code owners
|
✅ No secrets were detected in the code. |
Codecov Report
@@ Coverage Diff @@
## dev #3492 +/- ##
==========================================
+ Coverage 71.32% 75.05% +3.73%
==========================================
Files 1343 881 -462
Lines 31681 17673 -14008
Branches 5960 4957 -1003
==========================================
- Hits 22596 13265 -9331
+ Misses 8840 4408 -4432
+ Partials 245 0 -245
Flags with carried forward coverage won't be shown. Click here to find out more.
|
asanchezr
reviewed
Sep 25, 2023
Comment on lines
+61
to
+62
| await formikRef.current?.submitForm(); | ||
| setIsValid(formikRef.current?.isValid ?? false); |
There was a problem hiding this comment.
I see other places doing:
var result = await (formikRef.current?.submitForm() ?? Promise.resolve());
setIsValid(...)why not use the same pattern here (awaiting the promise)?
asanchezr
reviewed
Sep 25, 2023
| @@ -117,6 +118,7 @@ export const ResearchContainer: React.FunctionComponent< | |||
| if (formikRef !== undefined) { | |||
| formikRef.current?.setSubmitting(true); | |||
| formikRef.current?.submitForm(); | |||
| setIsValid(formikRef.current?.isValid || false); | |||
There was a problem hiding this comment.
Other code awaits the result of submitForm() but this one doesn't. Would it make sense to apply the same pattern here?
asanchezr
approved these changes
Sep 25, 2023
devinleighsmith
force-pushed
the
psp-6864
branch
from
a1744ee to
bc3f1f5
Compare
devinleighsmith
force-pushed
the
psp-6864
branch
from
bc3f1f5 to
00a4f72
Compare
|
✅ No secrets were detected in the code. |
1 similar comment
|
✅ No secrets were detected in the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.