PSP-7228 Management summary lease information - text change (#3588)

bcgov · Nov 10, 2023 · 1d8811d · 1d8811d
1 parent fbfd704
commit 1d8811d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/...DetailsManagement/detail/summary/__snapshots__/PropertyManagementDetailView.test.tsx.snap b/...DetailsManagement/detail/summary/__snapshots__/PropertyManagementDetailView.test.tsx.snap
@@ -161,7 +161,7 @@ exports[`PropertyManagementDetailView component renders as expected when provide
         <div
           class="c5 text-left col"
         >
-          No active Lease/License
+          No
         </div>
       </div>
       <div

diff --git a/...DetailsManagement/update/summary/__snapshots__/PropertyManagementUpdateForm.test.tsx.snap b/...DetailsManagement/update/summary/__snapshots__/PropertyManagementUpdateForm.test.tsx.snap
@@ -275,7 +275,7 @@ exports[`PropertyManagementUpdateForm component renders as expected 1`] = `
             <div
               class="c5 text-left col"
             >
-              No active Lease/License
+              No
             </div>
           </div>
           <div

diff --git a/...features/mapSideBar/property/tabs/propertyDetailsManagement/update/summary/models.test.ts b/...features/mapSideBar/property/tabs/propertyDetailsManagement/update/summary/models.test.ts
@@ -18,7 +18,7 @@ describe('Property management model tests', () => {
       expect(model.additionalDetails).toBe('');
       expect(model.isTaxesPayable).toBe(null);
       expect(model.isUtilitiesPayable).toBe(null);
-      expect(model.formattedLeaseInformation).toBe('No active Lease/License');
+      expect(model.formattedLeaseInformation).toBe('No');
     });
 
     it('fromApi sets values as expected from api response', () => {
@@ -35,11 +35,11 @@ describe('Property management model tests', () => {
       expect(model.additionalDetails).toBe('test');
       expect(model.isTaxesPayable).toBe(null);
       expect(model.isUtilitiesPayable).toBe(null);
-      expect(model.formattedLeaseInformation).toBe('No active Lease/License');
+      expect(model.formattedLeaseInformation).toBe('No');
     });
 
     it.each([
-      ['NO lease found', 0, null, 'No active Lease/License'],
+      ['NO lease found', 0, null, 'No'],
       ['ONE lease with expiry date', 1, '2020-03-15', 'Yes (Mar 15, 2020)'],
       ['ONE lease with no expiry date', 1, null, 'Yes'],
       ['MULTIPLE leases', 5, null, 'Multiple'],

diff --git a/source/frontend/src/utils/propertyUtils.ts b/source/frontend/src/utils/propertyUtils.ts
@@ -100,7 +100,7 @@ export function formatApiPropertyManagementLease(base?: Api_PropertyManagement |
   const count = base?.relatedLeases || 0;
   switch (count) {
     case 0:
-      return 'No active Lease/License';
+      return 'No';
 
     case 1:
       const expiryDate = base?.leaseExpiryDate ? `(${prettyFormatDate(base.leaseExpiryDate)})` : '';
-Original file line number
+Diff line change
@@ Expand Up @@
             <div
               class="c5 text-left col"
             >
-              No active Lease/License
+              No
             </div>
           </div>
           <div
@@ Expand Down @@