psp-7034 add warning message when attempting to remove an acquisition… · bcgov/PSP@e7906eb

Triggered via pull request October 20, 2023 22:39

opened #3529

Status Success

Total duration 8m 33s

Artifacts –

api-dotnetcore.yml

on: pull_request

11 warnings

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

build-backend: source/backend/core/Json/NullJsonResultFilter.cs#L5

Remove this unnecessary 'using'.

build-backend: source/backend/core/Extensions/QueryableExtensions.cs#L17

Make sure that this accessibility bypass is safe here.

build-backend: source/backend/core/Json/NullJsonResultFilter.cs#L20

Add a nested comment explaining why this method is empty, throw a 'NotSupportedException' or complete the implementation.

build-backend: source/backend/core/Extensions/DictionaryExtensions.cs#L70

Extract this nested ternary operation into an independent statement.

build-backend: source/backend/core/Extensions/DictionaryExtensions.cs#L106

Extract this nested ternary operation into an independent statement.

build-backend: source/backend/entities/Partials/AcqChklstSectionType.cs#L23

Either remove or fill this block of code.

build-backend: source/backend/entities/Partials/AcqChklstItemType.cs#L29

Either remove or fill this block of code.

build-backend: source/backend/entities/Partials/AcqChklstItemType.cs#L29

Use the 'value' parameter in this property set accessor declaration.

build-backend: source/backend/dal/Repositories/AcquisitionFilePropertyRepository.cs#L8

Remove this unnecessary 'using'.

build-backend: source/backend/dal/Repositories/AgreementRepository.cs#L7

Remove this unnecessary 'using'.