-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-2254 Late Notification Warning #2884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new function does check for the past pending notifications, sends them to queue and update the status for completion. Tested to receive email notification on projects with pending statuses past their send date.
This ticket can be merged to main when the promise call in Failedemailcheck to log error messages is altered.
Update call has been edited so that any failed updates will not interfere with others. |
🎯 Summary
PIMS-2254
Changes
node-cron
package to run this job on a schedule. We had previously removed it when we moved away from Keycloak-roles.PIMS System <[email protected]>
between the error report and notification warning emails.Testing
Make sure your .env file has these set:
server.ts
file to* * * * *
. This should make it fire every minute.To see a copy of the email, set some existing notifications to Pending like noted above, but comment out lines 43-47 of
failedEmailCheck.ts
. This will keep those notifications as Pending, so the email will be triggered.🔰 Checklist