Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-2245: Update @eslint/js, @faker-js/faker, @types/node, eslint, prettier, typescript, typescript-eslint #2874

Merged
merged 25 commits into from
Dec 4, 2024
Merged

PIMS-2245: Update @eslint/js, @faker-js/faker, @types/node, eslint, prettier, typescript, typescript-eslint #2874

Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
fb9e611
Update eslint from version 9.10.0 to 9.11.1
Sharala-Perumal Sep 25, 2024
544030d
Merge branch 'main' of https://github.com/bcgov/PIMS
Sharala-Perumal Sep 25, 2024
84c1998
Merge branch 'main' of https://github.com/bcgov/PIMS
Sharala-Perumal Oct 2, 2024
fe60759
Merge branch 'main' of https://github.com/bcgov/PIMS
Sharala-Perumal Oct 2, 2024
c428bb4
Merge branch 'main' of https://github.com/bcgov/PIMS
Sharala-Perumal Oct 9, 2024
5724fcf
Merge branch 'main' of https://github.com/bcgov/PIMS
Sharala-Perumal Oct 17, 2024
219a36d
Merge branch 'main' of https://github.com/bcgov/PIMS
Sharala-Perumal Oct 18, 2024
4da925a
Merge branch 'main' of https://github.com/bcgov/PIMS
Sharala-Perumal Oct 23, 2024
6b2be7e
Merge branch 'main' of https://github.com/bcgov/PIMS
Sharala-Perumal Oct 23, 2024
be33be6
Merge branch 'main' of https://github.com/bcgov/PIMS
Sharala-Perumal Oct 29, 2024
c5e1431
Merge branch 'main' of https://github.com/bcgov/PIMS
Sharala-Perumal Nov 5, 2024
25ffea5
Merge branch 'main' of https://github.com/bcgov/PIMS
Sharala-Perumal Nov 13, 2024
a02818d
Update react-router-dom
Sharala-Perumal Nov 13, 2024
88c8ba7
Merge branch 'main' of https://github.com/bcgov/PIMS
Sharala-Perumal Nov 13, 2024
181d285
Merge branch 'main' of https://github.com/bcgov/PIMS
Sharala-Perumal Nov 14, 2024
89fb055
Merge branch 'main' of https://github.com/bcgov/PIMS
Sharala-Perumal Nov 19, 2024
78affc0
Upgrade @eslint/js to 9.16.0
Sharala-Perumal Dec 3, 2024
556db52
Update @faker-js/faker to 9.3.0
Sharala-Perumal Dec 3, 2024
c647a88
Update @types/node to 22.10.1
Sharala-Perumal Dec 3, 2024
60b8efb
Updated eslint, typescript, and @typescript-eslint
Sharala-Perumal Dec 3, 2024
e59a21c
Update prettier to 3.4.1
Sharala-Perumal Dec 3, 2024
c1768d5
Merge branch 'main' into PIMS-2245
Sharala-Perumal Dec 3, 2024
29289b7
Updated ProjectServices.ts file
Sharala-Perumal Dec 3, 2024
67abffb
restore null deleted fields
dbarkowsky Dec 4, 2024
1bbc913
fix implicit any warning
dbarkowsky Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions express-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,31 +44,31 @@
"zod": "3.23.3"
},
"devDependencies": {
"@eslint/js": "9.15.0",
"@faker-js/faker": "9.2.0",
"@eslint/js": "9.16.0",
"@faker-js/faker": "9.3.0",
"@types/compression": "1.7.4",
"@types/cookie-parser": "1.4.5",
"@types/cors": "2.8.15",
"@types/express": "4.17.20",
"@types/jest": "29.5.10",
"@types/morgan": "1.9.9",
"@types/multer": "1.4.11",
"@types/node": "22.9.0",
"@types/node": "22.10.1",
"@types/nunjucks": "3.2.6",
"@types/supertest": "6.0.2",
"@types/swagger-jsdoc": "6.0.4",
"@types/swagger-ui-express": "4.1.6",
"cross-env": "7.0.3",
"eslint": "9.15.0",
"eslint": "9.16.0",
"eslint-config-prettier": "9.1.0",
"eslint-plugin-prettier": "5.2.1",
"jest": "29.7.0",
"nodemon": "3.1.0",
"prettier": "3.3.0",
"prettier": "3.4.1",
"supertest": "7.0.0",
"ts-jest": "29.2.0",
"tsc-alias": "1.8.8",
"typescript": "5.6.2",
"typescript-eslint": "8.15.0"
"typescript": "5.7.2",
"typescript-eslint": "8.17.0"
}
}
4 changes: 2 additions & 2 deletions express-api/src/services/projects/projectsServices.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,8 +556,8 @@ const handleProjectAgencyResponses = async (
...resp,
ProjectId: newProject.Id,
CreatedById: newProject.CreatedById,
DeletedById: null,
DeletedOn: null,
DeletedById: newProject.DeletedById,
DeletedOn: newProject.DeletedOn,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may change how the agency responses are handled by overwriting deleted responses' "Deleted" fields. Will test.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to change this back. If we don't reset these to null, then the agency's interest record cannot be added again once removed.

})),
);
}
Expand Down
Loading