PIMS-1946 Cancel/Stop Notifications

[dbarkowsky]

🎯 Summary

PIMS-1946

Tackles two issues with the notifications:

• Notifications previously queued when a project was cancelled were still being sent.
• Notifications were being re-sent when a project returned to a previous status.

Changes

• If a project is cancelled, Pending and Accepted notifications will be cancelled.
• If a project's status is changed, the notifications are only queued if this status is not in the project's history.

Testing

• Alter the status of a project in and out of the statuses that queue notifications (Approved for ERP, Submitted)
  • See that repeat notifications should not be queued.
• Change the agency interest values
  • See that the interest values should be updated still
• Cancel a project with pending notifications
  • See that those notifications are now cancelled too

🔰 Checklist

• I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.

• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation where required.
• I have tested my changes to the best of my ability.
• My changes generate no new warnings.

[github-actions]

🚀 Deployment Information

The Express API Image has been built with the tag: 2726. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

[codeclimate]

Code Climate has analyzed commit e1466fc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 91.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.4%.

View more on Code Climate.

[LawrenceLau2020]

Changing a project status back to Submitted and back to Approved for ERP doesn't trigger email notifications anymore 👍
When cancelling a project, I was expecting a notification, but didn't get one for some reason.

[dbarkowsky]

Changing a project status back to Submitted and back to Approved for ERP doesn't trigger email notifications anymore 👍 When cancelling a project, I was expecting a notification, but didn't get one for some reason.

Didn't realize there was a notification for cancelled projects. I've updated the way the notifications are generated a little. It should now still generate regular notifications for the cancellation.

[LawrenceLau2020]

Working well now, tested all the statuses that trigger notifications: cancelled, denied, submitted, & ERP statuses all get triggered "one time" if a project hasn't been in that status before.