Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-2094: Update typescript-eslint from version 8.4.0 to 8.6.0 in react-app #2690

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

Sharala-Perumal
Copy link
Collaborator

PIMS-2094: Update typescript-eslint from version 8.4.0 to 8.6.0 in react-app

When you run npm run lint you may get a a warning as shown below, but that didn't seems to affect any typescript files.

=============

WARNING: You are currently running a version of TypeScript which is not officially supported by @typescript-eslint/typescript-estree.

You may find that it works just fine, or you may not.

SUPPORTED TYPESCRIPT VERSIONS: >=4.7.4 <5.6.0

YOUR TYPESCRIPT VERSION: 5.6.2

Please only submit bug reports when using the officially supported version.

=============

🎯 Summary

PIMS-2094

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2690. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested alongside typescript update. Linting working despite warning.

@Sharala-Perumal Sharala-Perumal merged commit 0464a7b into main Sep 18, 2024
8 checks passed
@Sharala-Perumal Sharala-Perumal deleted the PIMS-2094 branch September 18, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants