Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-2000: Make non-optional checkboxes mandatory #2640

Merged
merged 10 commits into from
Sep 9, 2024

Conversation

LawrenceLau2020
Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 commented Aug 22, 2024

🎯 Summary

PIMS-2000:

  • Added the required option for the project tasks, now all the tasks in the "Confirm Tasks" section are required to be checked off before a user can submit the project.
  • After the migration is run, the "Review Completed" task should be one of the required checkboxes that appear when changing a project status to either "Approved for ERP" or "Approved for Exemption"
  • Also moved timestamp type, id#11 "RequestForSplReceivedOn" to the Approved for SPL Status and updated the task 'Preparation and Due Diligence complete' to a required field.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2640. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

@LawrenceLau2020 LawrenceLau2020 marked this pull request as draft August 22, 2024 23:29
Copy link

codeclimate bot commented Aug 26, 2024

Code Climate has analyzed commit 52b753b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.1%.

View more on Code Climate.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally, this is a good fix.
Before we approve and merge, I wouldn't mind getting Josh's opinion on whether he wants to be restricted on all these fields.
For example, if we look at the list to get into Approved for ERP:
image
It feels like you wouldn't likely check off both Appraisal fields or both Consultation fields at the same time, but you can't save the project if they aren't.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Contract is conditional is currently required, but that should be an optional task Updated the migration to handle this.
  • Noticing that the required field error message will stay between statuses, even if the new field is not required. I wonder if there's a way to force it to reset the error state. Solved this one. Change pushed.
    image

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the two changes noted in the last comment.
Everything appears to be working as expected.
Can't progress to a new project status without these required fields now.

@LawrenceLau2020 LawrenceLau2020 merged commit 132f2b7 into main Sep 9, 2024
13 checks passed
@LawrenceLau2020 LawrenceLau2020 deleted the PIMS-2000-MandatoryCheckboxes branch September 9, 2024 20:42
dbarkowsky added a commit that referenced this pull request Sep 11, 2024
Co-authored-by: dbarkowsky <[email protected]>
Co-authored-by: Dylan Barkowsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants