Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1929: Unknown status for project notifications #2628

Merged
merged 8 commits into from
Aug 15, 2024
Merged

Conversation

LawrenceLau2020
Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 commented Aug 14, 2024

🎯 Summary

PIMS-1929:

Changes

Testing

  • Since most of the notifications you will have in your localhost are from production, you can use the CHES dev credentials in your .env, then create a new project. To trigger a 404 not found, you can change one of the characters in the ChesMessageId column for the record in the NotificationQueue table where the notifications are stored.

  • With existing projects from production, you should still see all the "completed" notifications, but the ones that were in a pending state will most likely display as "Not Found" if you are using the CHES dev credentials.

  • Triggering a 422 is kind of tricky and I haven't found a way of doing it other than hard coding the request using an incorrectly formatted CHES Message id which is missing one character for example.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2628. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Aug 14, 2024

Code Climate has analyzed commit 2dd9689 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.7%.

View more on Code Climate.

Copy link

🚀 Deployment Information

The React APP Image has been built with the tag: 2628. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested following the instructions in the PR.
Everything seems to work as expected. Messages set to Not Found if CHES gives 404 back.
Please merge after test coverage is added.

@LawrenceLau2020 LawrenceLau2020 merged commit 82cbf4b into main Aug 15, 2024
13 checks passed
@LawrenceLau2020 LawrenceLau2020 deleted the PIMS-1929 branch August 15, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants