-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-1884 Swagger Rework #2621
PIMS-1884 Swagger Rework #2621
Conversation
🚀 Deployment Information The Express API Image has been built with the tag: |
Code Climate has analyzed commit b955e59 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 83.7% (50% is the threshold). This pull request will bring the total coverage in the repository to 93.2%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new swagger docs looks good, tested a couple endpoints and works well.
Also tested admin areas, agencies, properties and projects tables, filtering still working well and cancelling/resending notifications updates the updatedById correctly. No issues found.
Co-authored-by: LawrenceLau2020 <[email protected]>
🎯 Summary
PIMS-1884
Swagger Autogen was not doing a sufficient job of generating documentation. Moving to a manually-defined documentation structure.
Follows this structure:
Changes
While writing documentation, these are the changes that happened as a result.
Testing
With the API running, go to this URL: http://localhost:5000/api-docs
To use any protected routes, copy your bearer token from the browser and use it in the authorization section
🔰 Checklist