-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS 1957/1958: Handle agency response change notifications #2610
PIMS 1957/1958: Handle agency response change notifications #2610
Conversation
…ations for agencies that have newly been added as subscribed to the project
…esponses. Fixed some issues with determening whether an existing notification was queued that was preventing new notifications from being queued.
🚀 Deployment Information The Express API Image has been built with the tag: |
Code Climate has analyzed commit 21b9cf9 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 87.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 93.8%. View more on Code Climate. |
Testing the "unsubscribe" options seems to work fine, after choosing an agency that had already had pending notifications, I added this agency and after clicking confirm I needed to refresh the page in order to see the updated table with the 3 cancelled notifications. Perhaps we can refresh the notifications table after the "confirm"? When testing the "subscribe" option, I was expecting to receive an email as well as seeing the notifications table get updated with the new agency interest, but didn't get an email so maybe this isn't being triggered after clicking "confirm"? |
…rent send date. Modified the logic in generateWatchNotifications to use the most recent project update date to determine the send date
…layed watch notifications. Also added some comments.
…he ProjectAgencyResponseDialog
Re-tested the agency interest by adding an interest for Emily Carr University, and there were 3 new pending notifications in the table after confirming. Then changed the interest to "Watch" which cancels the notification, and then changing the interest back to "Subscribe" will create 3 new "pending" notifications for this agency as well. The notifications table is refreshing nicely as well, so I'm going to approve this ticket. |
… of github.com:bcgov/PIMS into PIMS-1957/1958-HandleAgencyResponseChangeNotifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last changes made the emails scheduled to send at correct times!
🎯 Summary
PIMS-1957
PIMS-1958
🔰 Checklist