Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1968: Add name to fuzzy search criteria #2608

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

LawrenceLau2020
Copy link
Collaborator

🎯 Summary

PIMS-1968:

Changes

  • Added the property name to the fuzzy search in the project form so you can search by the building or parcel name.
  • Increased the limit to 5 records.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

codeclimate bot commented Aug 7, 2024

Code Climate has analyzed commit 9154024 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.9%.

View more on Code Climate.

Copy link

github-actions bot commented Aug 7, 2024

🚀 Deployment Information

The Express API Image has been built with the tag: 2608. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

github-actions bot commented Aug 7, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2608. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me. Was able to search by names of parcels and buildings.
The max height of the options means the extra quantity isn't an issue. 👍

@LawrenceLau2020 LawrenceLau2020 merged commit 5df4fc2 into main Aug 7, 2024
13 checks passed
@LawrenceLau2020 LawrenceLau2020 deleted the PIMS-1968 branch August 7, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants